-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/xygu/20230823/shadow-rework #752
Conversation
todo:
---
|
b17f4e6
to
8abcbc5
Compare
8abcbc5
to
f633ff0
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
44e1ba3
to
d5407b6
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
d5407b6
to
ccbef6e
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
ccbef6e
to
bc6763b
Compare
bc6763b
to
86087e4
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reviewing from a iPhone, and there are a lot of changes here so I'm only addressing an obvious issue: why remove the detection of child corner radius?
For now we only support children with corner radius, but later we could support text or images. In those cases the path for the shadows will be detected just as we detect children corner radius.
We need to determine the aspect of the shadows from the child.
it all got moved to .ShadowContainer.cs as BindToPaintingProperties $class-name.properties.cs should stay pure, nothing more than dependency property definitions |
bc18145
to
c8c485f
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowContainer.Paint.cs
Outdated
Show resolved
Hide resolved
FYI @roubachof ^ Just to make sure you saw the response to your concerns |
c8c485f
to
ccd12ca
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
ccd12ca
to
645f455
Compare
645f455
to
a8e6843
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
@kazo0 @Xiaoy312 I stand by what I said. Child CornerRadius detection has been removed and the corner radius with this PR is now directly provided by the container itself. |
src/Uno.Toolkit.Skia.WinUI/Controls/Shadows/ShadowContainer.Paint.cs
Outdated
Show resolved
Hide resolved
1cd6cd7
to
823ab6a
Compare
823ab6a
to
b57d6e6
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-752.eastus2.azurestaticapps.net |
@Xiaoy312 / @kazo0 / @jeromelaban Line 15 in f760d54
![]() |
@agneszitte if it's not impacting the gallery, we can do it in a separate PR |
@Xiaoy312 some runtime tests would also need to be added in a separated PR, please |
@Mergifyio backport legacy/3x |
✅ Backports have been created
|
GitHub Issue (If applicable): closes #707
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
n/a