fix: skia and IOS shadows not updating properly

[Marc-Antoine-Soucy]

GitHub Issue (If applicable): #748

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

Right now, on skia, and IOS you add a shadow to a shadow container and increase the size of the shadow content, the shadows appear too small,

What is the new behavior?

They stay the right size and visible

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Tested the changes where applicable:
  • UWP
  • WinUI
  • iOS
  • Android
  • WASM Could not build
  • MacOS
• Updated the documentation as needed:
  • General Doc Update
  • Controls Doc Update
  • Extensions Doc Update
  • controls-styles.md
  • lightweight-styling.md (LightWeight Styling Resource Keys)
• Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
• Contains NO breaking changes
• Associated with an issue (GitHub or internal)
• Commits must be following the Conventional Commits specification.

[github-actions]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-756.eastus2.azurestaticapps.net

[github-actions]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-756.eastus2.azurestaticapps.net

[Marc-Antoine-Soucy]

Maybe ActualWidth/Height from both contentAsFE and _shadowHost should be in the key, to make sure we don't get another bug like that again?

[github-actions]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-756.eastus2.azurestaticapps.net

[agneszitte]

Should we add some tests for this @jeromelaban? Or on a following PR?

[jeromelaban]

Should we add some tests for this @jeromelaban? Or on a following PR?

Definitely. This looks like a behavior that can break easily, I'd also say that using formatting for this type of keying is probably not the most performant way to do so.

@Marc-Antoine-Soucy let's merge this PR if it's approved by the rest of the team, but make sure to add a create a new PR right after that will add regression testing. I've removed the automatic closing of the issue so we can keep track of this.

[agneszitte]

Should we add some tests for this @jeromelaban? Or on a following PR?

Definitely. This looks like a behavior that can break easily, I'd also say that using formatting for this type of keying is probably not the most performant way to do so.

@Marc-Antoine-Soucy let's merge this PR if it's approved by the rest of the team, but make sure to add a create a new PR right after that will add regression testing. I've removed the automatic closing of the issue so we can keep track of this.

@jeromelaban, @Marc-Antoine-Soucy I entered an issue for tracking
#791

[agneszitte]

@Mergifyio backport legacy/3x release/stable/3.1

[mergify]

backport legacy/3x release/stable/3.1

✅ Backports have been created

• #792 fix: skia and IOS shadows not updating properly (backport #756) has been created for branch legacy/3x
• #793 fix: skia and IOS shadows not updating properly (backport #756) has been created for branch release/stable/3.1