Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lightweight styling to divider #765

Merged
merged 2 commits into from
Aug 30, 2023
Merged

feat: add lightweight styling to divider #765

merged 2 commits into from
Aug 30, 2023

Conversation

Marc-Antoine-Soucy
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

There's not lightweight styling and the foreground of the divider is not following the latest figma file.

What is the new behavior?

Correct the foreground color and added lightweight styling and documentation

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Xiaoy312
Xiaoy312 reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else seems good~

doc/controls/Divider.md Outdated Show resolved Hide resolved
@kazo0
Copy link
Contributor

kazo0 commented Aug 29, 2023 •
edited
Loading

@Mergifyio backport legacy/3x release/stable/3.1

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023 •
edited
Loading

backport legacy/3x release/stable/3.1

✅ Backports have been created

@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/dividerlightweight branch 2 times, most recently from 09810f6 to 89cd657 Compare August 29, 2023 18:40
@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as draft August 29, 2023 18:40
@Marc-Antoine-Soucy
Copy link
Contributor Author

Waiting for new material package containing OutlineVariantBrush

agneszitte
agneszitte reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need an update here for the doc to add divider for lightweight styling here please https://github.com/unoplatform/uno.toolkit.ui/blob/main/doc/lightweight-styling.md#resource-keys
In this list:
image

@agneszitte
Copy link
Contributor

agneszitte commented Aug 29, 2023 •
edited
Loading

Waiting for new material package containing OutlineVariantBrush

@Marc-Antoine-Soucy 3.0.0-dev.349 is now available on nuget.org for you to have the OutlineVariantBrush
(Please keep Uno.Material and Uno.Cupertino versions in sync while doing the update)

@agneszitte agneszitte linked an issue Aug 29, 2023 that may be closed by this pull request
[Gallery][iOS/Android/] Checkbox, Radio button and Toggleswitch- For label, discrepancy in font size. unoplatform/Uno.Gallery#901
Closed
@Marc-Antoine-Soucy
Copy link
Contributor Author

Waiting for new material package containing OutlineVariantBrush

@Marc-Antoine-Soucy 3.0.0-dev.349 is now available on nuget.org for you to have the OutlineVariantBrush (Please keep Uno.Material and Uno.Cupertino versions in sync while doing the update)

I quickly tested to make sure it builds on every platform (and that my changes are there), do we need to do more than that when updating material/cupertino nugets?

@Marc-Antoine-Soucy Marc-Antoine-Soucy marked this pull request as ready for review August 30, 2023 12:53
agneszitte
agneszitte reviewed Aug 30, 2023
View reviewed changes
doc/controls/Divider.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-765.eastus2.azurestaticapps.net

@agneszitte agneszitte merged commit cd6b89a into main Aug 30, 2023
24 checks passed
@agneszitte agneszitte deleted the dev/maso/dividerlightweight branch August 30, 2023 19:40
mergify bot pushed a commit that referenced this pull request Aug 30, 2023
@Marc-Antoine-Soucy @mergify
feat: add lightweight styling to divider (#765)
a8e62db 
(cherry picked from commit cd6b89a)

# Conflicts:
#	samples/Directory.Packages.props
#	src/Directory.Packages.props
@mergify mergify bot mentioned this pull request Aug 30, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 30, 2023
@Marc-Antoine-Soucy @mergify
feat: add lightweight styling to divider (#765)
2b01d37 
(cherry picked from commit cd6b89a)

# Conflicts:
#	samples/Directory.Packages.props
#	src/Directory.Packages.props
@mergify mergify bot mentioned this pull request Aug 30, 2023
Merged
Marc-Antoine-Soucy added a commit that referenced this pull request Aug 30, 2023
@Marc-Antoine-Soucy
feat: add lightweight styling to divider (backport #765)
c337002
Marc-Antoine-Soucy added a commit that referenced this pull request Aug 30, 2023
@Marc-Antoine-Soucy
feat: add lightweight styling to divider (backport #765)
50951cd
agneszitte pushed a commit that referenced this pull request Aug 30, 2023
@mergify @Marc-Antoine-Soucy
feat: add lightweight styling to divider (backport #765) (#784)
29d1c9a 
Co-authored-by: Marc-Antoine Soucy <ma.soucy@nventive.com>
agneszitte added a commit that referenced this pull request Aug 31, 2023
@agneszitte
feat: add lightweight styling to divider (#765)
9a149bb 
(cherry picked from commit cd6b89a)

# Conflicts:
# samples/Directory.Packages.props
# src/Directory.Packages.props
agneszitte added a commit that referenced this pull request Aug 31, 2023
@mergify @agneszitte
feat: add lightweight styling to divider (backport #765) (#785)
91d8e0b 
Co-authored-by: agneszitte <agnes@platform.uno>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 left review comments

@kazo0 kazo0 kazo0 approved these changes

@agneszitte agneszitte agneszitte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Gallery][iOS/Android/] Checkbox, Radio button and Toggleswitch- For label, discrepancy in font size.
4 participants
@Marc-Antoine-Soucy @kazo0 @agneszitte @Xiaoy312