Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ShadowContainer): ensure canvas does not have negative dimension #804

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix(ShadowContainer): ensure canvas does not have negative dimension #804

merged 1 commit into from
Sep 4, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Sep 3, 2023

fixes #803

@kazo0
Copy link
Contributor Author

kazo0 commented Sep 3, 2023

@Mergifyio backport legacy/3x

@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2023 •
edited
Loading

backport legacy/3x

✅ Backports have been created

@github-actions
Copy link

github-actions bot commented Sep 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-804.eastus2.azurestaticapps.net

@agneszitte
Copy link
Contributor

agneszitte commented Sep 4, 2023 •
edited
Loading

@Mergifyio backport release/stable/3.1

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2023 •
edited
Loading

backport release/stable/3.1

✅ Backports have been created

@unoplatform unoplatform deleted a comment from mergify bot Sep 4, 2023
@agneszitte agneszitte merged commit 070bee8 into main Sep 4, 2023
24 checks passed
@agneszitte agneszitte deleted the dev/sb/shadows-neg-dimen branch September 4, 2023 16:02
mergify bot pushed a commit that referenced this pull request Sep 4, 2023
@kazo0 @mergify
fix(ShadowContainer): ensure canvas does not have negative dimension (#…
726344e 
…804)

(cherry picked from commit 070bee8)

# Conflicts:
#	src/Uno.Toolkit.RuntimeTests/Tests/ShadowContainerTests.cs
@mergify mergify bot mentioned this pull request Sep 4, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 4, 2023
@kazo0 @mergify
fix(ShadowContainer): ensure canvas does not have negative dimension (#…
fa78923 
…804)

(cherry picked from commit 070bee8)

# Conflicts:
#	src/Uno.Toolkit.RuntimeTests/Tests/ShadowContainerTests.cs
@mergify mergify bot mentioned this pull request Sep 4, 2023
Merged
agneszitte pushed a commit that referenced this pull request Sep 5, 2023
@mergify @kazo0
fix(ShadowContainer): ensure canvas does not have negative dimension …
4dcc118 
…(backport #804) (#810)

Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
fix(ShadowContainer): ensure canvas does not have negative dimension (#804)
agneszitte pushed a commit that referenced this pull request Sep 5, 2023
@mergify @kazo0
fix(ShadowContainer): ensure canvas does not have negative dimension …
e4104ef 
…(backport #804) (#811)

Co-authored-by: Steve Bilogan <steve.bilogan@gmail.com>
fix(ShadowContainer): ensure canvas does not have negative dimension (#804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ShadowContainer] Canvas can be set to a negative Height/Width, crashing on Windows
2 participants
@kazo0 @agneszitte