Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sample): broken uwp nav-view #996

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

Xiaoy312
Copy link
Contributor

GitHub Issue (If applicable): closes #544

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

nav-view item is stuck on compact mode while the nav-view is in full mode

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

This was caused by NavView was somehow set to the "ListSizeFull" state, after the initialization.

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240111/uwp-broken-nav-view branch from 3fe2311 to d28eeed Compare January 12, 2024 00:51
@Xiaoy312
Copy link
Contributor Author

toolkit sample nav

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20240111/uwp-broken-nav-view branch from d28eeed to 33dac6c Compare January 12, 2024 15:14
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-996.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit fca3d86 into main Jan 16, 2024
26 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20240111/uwp-broken-nav-view branch January 16, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sample App] NavigationView is almost unusable in the sample app in this repository
2 participants