Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationView update #864

Merged
merged 4 commits into from
Oct 20, 2022
Merged

NavigationView update #864

merged 4 commits into from
Oct 20, 2022

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Oct 18, 2022

GitHub Issue: close #862

PR Type

What kind of change does this PR introduce?

  • Bugfixes
  • Feature

Description

  • updated material NV and NVI styles to M3 standard, with adaptive support (PaneDisplayMode=Auto) between navigation drawer and rails (in M3 terms).
  • updated the sample app in accordance to the NV changes: minor layout adjustment + added menu item icons (otherwise compact mode would just display nothing)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

@Xiaoy312 Xiaoy312 changed the title chore: bump Microsoft.UI.Xaml to 2.6.2 NavigationView update Oct 18, 2022
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Oct 18, 2022

preview:
nv resizing

fixme:

  • revert 2.6.2 bump and swap out AnimatedIcon for font icon?
    ^ ProgressRing.XyzSource were in 2.6.0-prerelease, but still not in 2.8.0-stable...
    ^ yet AnimatedIcon depends on at least 2.6.0 stable...
  • ^ made a compromise: the library will continue to be built with 2.6.0-prerelease.numbers; but, the sample app is updated to 2.6.2. the reasoning is the the follow:

    Important Note: Beside the AnimatedIcon problem that can be bypassed, the prerelease version also introduces another problem with
    the layout of the back/close/toggle/nvi icons which we are unable to fix here (incompatible MinWidth+Margin injected from the control implementation).
    Because of that, the consuming app should be at least on 2.6.0, which shouldn't be a problem as recent unoapp template has been on 2.6.2 for a while.

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-864.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-864.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-864.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 marked this pull request as ready for review October 20, 2022 00:50
@Xiaoy312 Xiaoy312 merged commit f1f0b06 into master Oct 20, 2022
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20221018/nav-view branch October 20, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material][NavView] add support for Compact mode
3 participants