Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextCommandBarFlyout is eagerly created when creating XamlControlsResources #6020

Closed
1 of 5 tasks
jeromelaban opened this issue May 17, 2021 · 1 comment
Closed
1 of 5 tasks

TextCommandBarFlyout is eagerly created when creating XamlControlsResources #6020

jeromelaban opened this issue May 17, 2021 · 1 comment
Labels
difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/bug Something isn't working kind/regression Something was working, now it isn't project/styling 👔 Categorizes an issue or PR as relevant to element styling
Milestone
3.8

Comments

@jeromelaban
Copy link
Member

Current behavior

An instance of XamlControlsResources when creating an instance of XamlControlsResources.

Expected behavior

Resources created by XamlControlsResources should be mostly lazy.

Environment

Nuget Package: 3.8-dev

  • Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia
  • Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia
  • Uno.SourceGenerationTasks
  • Uno.UI.RemoteControl / Uno.WinUI.RemoteControl
  • Other:
@jeromelaban jeromelaban added kind/bug Something isn't working kind/regression Something was working, now it isn't project/styling 👔 Categorizes an issue or PR as relevant to element styling difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding labels May 17, 2021
@jeromelaban
Copy link
Member Author

@davidjohnoliver I recall that we're creating some instances eagerly (like colors and others, but it feels like DependencyObject base types should not be. Do you remember why this is the case?

@jeromelaban jeromelaban added this to the 3.8 milestone May 17, 2021
@jeromelaban jeromelaban mentioned this issue May 17, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/bug Something isn't working kind/regression Something was working, now it isn't project/styling 👔 Categorizes an issue or PR as relevant to element styling
Projects
None yet
Milestone
3.8
Development

No branches or pull requests
1 participant
@jeromelaban