ButtonBase.Click refactoring to be raised before the Tapped event bubbling #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jeromelaban
approved these changes
Jun 5, 2019
src/Uno.UI/UI/Xaml/Controls/Primitives/ButtonBase/ButtonBase.wasm.cs
Outdated
Show resolved
Hide resolved
dr1rrb
approved these changes
Jun 5, 2019
src/Uno.UI/UI/Xaml/Controls/Primitives/ButtonBase/ButtonBase.wasm.cs
Outdated
Show resolved
Hide resolved
carldebilly
force-pushed
the
dev/cdb/button-click
branch
from
0d86cb8
to
bbe2c76
Compare
9 tasks
carldebilly
force-pushed
the
dev/cdb/button-click
branch
from
bbe2c76
to
631fc44
Compare
jeromelaban
added
the
do-not-merge/work-in-progress
|
This #1227 looks like the current issue maybe addressed by this PR. |
carldebilly
force-pushed
the
dev/cdb/button-click
branch
from
631fc44
to
ad00e1d
Compare
carldebilly
removed
the
do-not-merge/work-in-progress
ghuntley
added
platform/android 🤖
carldebilly
force-pushed
the
dev/cdb/button-click
branch
from
7a2a62d
to
c7f4dd2
Compare
jeromelaban
reviewed
Jul 24, 2019
...sApp/SamplesApp.UITests/Windows_UI_Xaml_Controls/ButtonTests/UnoSamples_Test_Button_Click.cs
Outdated
Show resolved
Hide resolved
carldebilly
force-pushed
the
dev/cdb/button-click
branch
from
78ed0ec
to
4198fdd
Compare
carldebilly
force-pushed
the
dev/cdb/button-click
branch
from
4198fdd
to
d83e4e2
Compare
|
@carldebilly android unit tests were failing (for good reasons it seems) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
The
Clickevent onButtonBasewas connected toTappedevent, causing problem when the event was handled in code.What is the new behavior?
The code is now ensuring the
Clickevent is always raised because theTappedevent starts bubbling-- on all platforms.
PR Checklist
Please check if your PR fulfills the following requirements:
[ ] Docs have been added/updated which fit [documentation template](https://github.com/nventive/Uno/blob/master/doc/.feature-template.md). (for bug fixes / features)[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)(there was already appropriate tests for that)Internal Issue (If applicable):