feat(template): Move to single location projects #10611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
area/build
|
The build 63287 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/remove-shared-projects
branch
from
5e03178
to
999430d
Compare
github-actions
bot
added
the
area/code-generation
|
The build 63372 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/remove-shared-projects
branch
from
f66fb38
to
bf52325
Compare
|
The build 63398 found UI Test snapshots differences: Details
|
|
The build 63417 found UI Test snapshots differences: Details
|
|
The build 63467 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/remove-shared-projects
branch
from
13d3bec
to
aa50cef
Compare
|
The build 63488 found UI Test snapshots differences: Details
|
|
The build 63501 found UI Test snapshots differences: Details
|
|
The build 63537 found UI Test snapshots differences: Details
|
dansiegel
reviewed
Dec 5, 2022
There was a problem hiding this comment.
The AndroidManifest.xml / Info.plist's should be updated the remove the properties set by the msbuild properties... so this:
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.companyname.$ext_safeprojectname$" android:versionCode="1" android:versionName="1.0">
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="31" />
<application android:label="$ext_safeprojectname$"></application>
</manifest>Would become:
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<application></application>
</manifest>NOTE: uses-sdk is injected automatically based on the SDK version it is built against and the minimum supported sdk set in the csproj
jeromelaban
force-pushed
the
dev/jela/remove-shared-projects
branch
from
948f11a
to
6755e47
Compare
spouliot
reviewed
Dec 6, 2022
There was a problem hiding this comment.
Do you can to marge #10357 before ? inside ? or after this PR ?
One of the nice things about the default net5+ .csproj is that they are small and used to change defaults.
In contrast the current .csproj for Uno apps are quite large. It would be nice to move a lot of the config into some files inside Uno.
|
@dansiegel good catch. There's already an issue about this unoplatform/uno.templates#232 |
This change removes the use of shared projects, which cause many issues insde VS, as well as VS Code (incorrect removal, incorrect addition of files, failure to properly explain how to include multiple nuget packages, complex vscode globbing).
jeromelaban
force-pushed
the
dev/jela/remove-shared-projects
branch
from
6755e47
to
90f32ef
Compare
|
Thanks for the reviews! Indeed, we can remove most of the content of the android xml file. |
github-actions
bot
added
the
platform/macos 🍏
|
You've also got this bit which can be removed from the Info.plist for the iOS, macOS, & MacCatalyst projects as these will be injected by the iOS/Mac SDK using the msbuild props <key>CFBundleDisplayName</key>
<string>$ext_safeprojectname$</string>
<key>CFBundleIdentifier</key>
<string>com.companyname.$ext_safeprojectname$</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<key>CFBundleVersion</key>
<string>1.0</string> |
spouliot
approved these changes
Dec 6, 2022
src/SolutionTemplate/UnoSolutionTemplate.WinUI.netcore/Skia.WPF/Platforms/Skia.Wpf/App.xaml
Show resolved
Hide resolved
dansiegel
approved these changes
Dec 6, 2022
|
The build 63757 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What is the new behavior?
This change removes the use of shared projects, which cause many issues insde VS, as well as VS Code (incorrect removal, incorrect addition of files, failure to properly explain how to include multiple nuget packages, complex vscode globbing).
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):