Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: BorderLayerRenderer #12593

Closed
wants to merge 68 commits into from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Jun 9, 2023

GitHub Issue (If applicable): closes #7621, closes #7110

Replaces #7649

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖 Generated by Copilot at acf61f2

This pull request improves the Fluent theme for Uno by using a new FauxGradientBorderPresenter control to simulate linear gradient border brushes on various controls across platforms. It also simplifies and harmonizes the theme resources and removes unnecessary platform-specific code. Additionally, it fixes some bugs and enhances some features in the ElevatedView and GtkTextBoxView classes, and adds some tests for potential memory leaks. It also deletes an unused file and cleans up some using directives.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform labels Jun 9, 2023
@mergify mergify bot mentioned this pull request Jun 9, 2023
6 tasks
@MartinZikmund MartinZikmund self-assigned this Jun 9, 2023
@jeromelaban jeromelaban marked this pull request as draft June 21, 2023 13:15
@jeromelaban jeromelaban changed the base branch from feature/5x to master June 29, 2023 15:32
@MartinZikmund
Copy link
Member Author

Closed in favor of #16482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fluent controls don't respect BorderThickness set to 0 Fake bottom gradient should respect BorderThickness
2 participants