Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GTK Window): Extend into Title Bar #13597

Merged

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Sep 11, 2023

GitHub Issue (If applicable): #10874, closes #10368

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

We can not extned into title bar in GTK

What is the new behavior?

We can use the Decorated window in GTK by set CoreApplication.GetCurrentView().TitleBar.ExtendViewIntoTitleBar = true

Copilot Summary

馃 Generated by Copilot at e1f5054

This pull request adds support for the ExtendViewIntoTitleBar feature on the Skia.Gtk platform. It enables the CoreApplicationViewTitleBar class and its property for Skia apps, and updates the window decoration accordingly.

PR Checklist

Please check if your PR fulfills the following requirements:


How can I add the UITest to test the application startup?

Can I know current application are running with GTK?

@github-actions github-actions bot added the area/skia 鉁忥笍 Categorizes an issue or PR as relevant to Skia label Sep 11, 2023
Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Thanks for the update.

Copy link
Member

@MartinZikmund MartinZikmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃憤馃憤

@MartinZikmund MartinZikmund merged commit 85ad12d into unoplatform:master Sep 13, 2023
84 checks passed
@lindexi
Copy link
Contributor Author

lindexi commented Sep 13, 2023

Thank you @MartinZikmund and @ajpinedam

@lindexi lindexi deleted the t/lindexi/ExtendViewIntoTitleBar branch March 6, 2024 08:21
@lindexi
Copy link
Contributor Author

lindexi commented Mar 6, 2024

Usage:

        var host = new GtkHost(() =>
        {
            var app = new AppHead();
            CoreApplication.GetCurrentView().TitleBar.ExtendViewIntoTitleBar = true;
            return app;
        });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/skia 鉁忥笍 Categorizes an issue or PR as relevant to Skia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Skia] Add support for Window.ExtendsContentIntoTitleBar
3 participants