Add support for dotnet new template #1520
Conversation
ghuntley
added
area/solution-templates
...Template/Uno.ProjectTemplates.Dotnet/content/xamarinforms-wasm/UnoQuickStart.Wasm/Program.cs
Outdated
Show resolved
Hide resolved
...Template/Uno.ProjectTemplates.Dotnet/content/xamarinforms-wasm/UnoQuickStart.Wasm/Program.cs
Show resolved
Hide resolved
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <PackageTags>dotnet-new;templates;uno-platform</PackageTags> |
There was a problem hiding this comment.
Shall we add xamarin.forms, xamarinforms or xamarin-forms? My vote is xamarin-forms or matching whatever the convention that .NET 5 is heading with tags. Dash is more UNIXy (👍)
NuGet uses a mixture of terms:
https://www.nuget.org/packages/Xamarin.Forms/
There was a problem hiding this comment.
Resolved but nothing has been done ;-)
| @@ -0,0 +1,10 @@ | |||
| /** | |||
There was a problem hiding this comment.
Duplicate of the same folder which will cause maintenance debt in the future. Can WasmCSS/* be referenced from else where or generated from the source tree or is it not worth doing?
...jectTemplates.Dotnet/content/xamarinforms-wasm/UnoQuickStart.Wasm/WasmScripts/AppManifest.js
Show resolved
Hide resolved
| "author": "Uno Platform", | ||
| "classifications": [ "Console" ], | ||
| "name": "Uno Platform WebAssembly Head for Xamarin.Forms", | ||
| "identity": "Uno.Platform.Wasm.XamarinForms", |
There was a problem hiding this comment.
A new naming convention, shall we run this by the team and double check before we get locked in? I read this as Uno.Platform.PLATFORM.PACKAGE-FOR-PLATFORM.
jeromelaban
force-pushed
the
dev/jela/xf-project-template
branch
2 times, most recently
from
9efc85c
to
e8b1cb9
Compare
jeromelaban
force-pushed
the
dev/jela/xf-project-template
branch
from
e8b1cb9
to
f114e21
Compare
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <PackageTags>dotnet-new;templates;uno-platform</PackageTags> |
There was a problem hiding this comment.
Resolved but nothing has been done ;-)
| }, | ||
| "primaryOutputs": [ | ||
| { "path": "UnoQuickStart.Wasm" } | ||
| // Cannot add the shared project because of path replace issues: https://github.com/dotnet/templating/issues/2068 |
There was a problem hiding this comment.
Not compliant with the json spec
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Introduce a base package to support
dotnet newsyntax.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):