Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Swallow Style setter exceptions as in WinUI #15240

Merged
merged 4 commits into from
Feb 2, 2024
Merged

fix: Swallow Style setter exceptions as in WinUI #15240

merged 4 commits into from
Feb 2, 2024

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #15131

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15240/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15240/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15240/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15240/index.html

@Youssef1313 Youssef1313 force-pushed the issues/15131 branch 6 times, most recently from 1b953b3 to fbadc74 Compare January 31, 2024 12:59
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15240/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15240/index.html

@jeromelaban jeromelaban mentioned this pull request Jan 31, 2024
Closed
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15240/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15240/index.html

jeromelaban
jeromelaban reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, could you also validate the screenshot tests, just in case?

src/Uno.UI/UI/Xaml/Style/Style.cs Outdated Show resolved Hide resolved
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15240/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15240/index.html

@jeromelaban jeromelaban merged commit 6a22670 into unoplatform:master Feb 2, 2024
92 checks passed
@Youssef1313 Youssef1313 deleted the issues/15131 branch February 2, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iurycarlos iurycarlos iurycarlos left review comments

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exceptions when applying a style setter are "swallowed" on WinUI
4 participants
@Youssef1313 @unodevops @jeromelaban @iurycarlos