Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skia hittesting with visuals #15875

Merged
merged 42 commits into from
Apr 11, 2024
Merged

Skia hittesting with visuals #15875

merged 42 commits into from
Apr 11, 2024

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #15854

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Mar 13, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@ramezgerges ramezgerges mentioned this pull request Mar 15, 2024
Closed
@ramezgerges
Copy link
Contributor Author

@dr1rrb I've found a problem after the latest changes with EVP and it turns out that ScrollContentPresenter (and probably all ScrollPorts) should NOT be affected by their own viewport clipping. Meaning that when you scroll a SCP, you should see the EVP effects appeering on the children, but not on the SCP itself. In a sense, the SCP is never "clipping by itself".

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@ramezgerges ramezgerges mentioned this pull request Mar 20, 2024
Merged
6 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

dr1rrb
dr1rrb reviewed Mar 21, 2024
View reviewed changes
src/Uno.UI.Composition/Composition/Visual.skia.cs Show resolved Hide resolved
src/Uno.UI.Composition/Composition/Visual.skia.cs Outdated Show resolved Hide resolved
src/Uno.UI.Composition/Composition/Visual.skia.cs Outdated Show resolved Hide resolved
src/Uno.UI.Composition/Composition/Visual.skia.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Controls/TextBlock/TextVisual.skia.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Media/VisualTreeHelper.cs Show resolved Hide resolved
src/Uno.UI.Composition/Composition/Visual.skia.cs Show resolved Hide resolved
src/Uno.UI.Composition/Composition/Visual.skia.cs Outdated Show resolved Hide resolved
src/Uno.UI.Composition/Composition/Visual.skia.cs Show resolved Hide resolved
src/Uno.UI/UI/Xaml/FrameworkElement.EffectiveViewport.cs Show resolved Hide resolved
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Mar 25, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@ramezgerges ramezgerges added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024
@ramezgerges ramezgerges marked this pull request as ready for review April 3, 2024 12:40
@ramezgerges ramezgerges removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2024
Youssef1313
Youssef1313 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for @dr1rrb's approval though.

@Youssef1313 Youssef1313 requested a review from dr1rrb April 7, 2024 21:18
@ramezgerges ramezgerges mentioned this pull request Apr 10, 2024
Draft
6 tasks
dr1rrb
dr1rrb reviewed Apr 10, 2024
View reviewed changes
src/Uno.UI.Composition/Composition/ContainerVisual.skia.cs Show resolved Hide resolved
src/Uno.UI.Composition/Composition/Visual.skia.cs Show resolved Hide resolved
src/Uno.UI.RuntimeTests/Helpers/ImageAssert.cs Outdated Show resolved Hide resolved
src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_RatingControl.cs Show resolved Hide resolved
src/Uno.UI/UI/Xaml/Media/VisualTreeHelper.cs Show resolved Hide resolved
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater.cs Outdated Show resolved Hide resolved
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_CompositionClip.cs Show resolved Hide resolved
src/Uno.UI/UI/Xaml/UIElement.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/UIElement.cs Show resolved Hide resolved
@ramezgerges ramezgerges added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@ramezgerges ramezgerges removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15875/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15875/index.html

@ramezgerges ramezgerges merged commit ebfbc23 into unoplatform:master Apr 11, 2024
101 checks passed
@ramezgerges ramezgerges deleted the skia_hittesting_with_visuals branch April 12, 2024 07:56
@Youssef1313 Youssef1313 mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr1rrb dr1rrb dr1rrb left review comments

@agneszitte agneszitte agneszitte left review comments

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TransformToVisual should rely on Visual's total matrix
5 participants
@ramezgerges @unodevops @dr1rrb @agneszitte @Youssef1313