Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use Markdown Video tag instead of iframe #16305

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

morning4coffe-dev
Copy link
Member

@morning4coffe-dev morning4coffe-dev commented Apr 15, 2024

GitHub Issue (If applicable): part of https://github.com/unoplatform/uno-private/issues/453

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

PR Checklist

Please check if your PR fulfills the following requirements:

@agneszitte
Copy link
Contributor

agneszitte commented Apr 15, 2024

@morning4coffe-dev Also be careful here when using closes here as it will automatically close the related issue when this PR is merged.

If it is working, we will need to update more than the Uno repo here, so multiple PRs will be needed for https://github.com/unoplatform/uno-private/issues/453.

cf. https://github.com/search?q=org%3Aunoplatform+src%3D%22https%3A%2F%2Fwww.youtube-nocookie.com%2Fembed%2F&type=code with all the repos where we are using <iframe /> at the moment

image

@morning4coffe-dev
Copy link
Member Author

Thank you @agneszitte, I updated the PR to be a part of. I didn't realize that otherones couln't be part of this PR.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16305/index.html

@morning4coffe-dev
Copy link
Member Author

Hmm, this is the resultof the Markdown Video tag:
image

@MartinZikmund
Copy link
Member

Is it possible that this would work without the > at the beginning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants