Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve Skia clipping #16502

Merged
merged 9 commits into from May 3, 2024
Merged

fix: Improve Skia clipping #16502

merged 9 commits into from May 3, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 29, 2024 •
edited

GitHub Issue (If applicable): closes #16501

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels Apr 29, 2024
@Youssef1313 Youssef1313 changed the title Clipping... [DRAFT] Improve Skia clipping Apr 29, 2024
@Youssef1313 Youssef1313 force-pushed the skia-clipping branch 4 times, most recently from e1e9523 to 95edebf Compare May 1, 2024 12:03
@github-actions github-actions bot removed the area/automation Categorizes an issue or PR as relevant to project automation label May 1, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16502/index.html

@Youssef1313 Youssef1313 changed the title [DRAFT] Improve Skia clipping fix: Improve Skia clipping May 1, 2024
@Youssef1313 Youssef1313 marked this pull request as ready for review May 1, 2024 14:08
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16502/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16502/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16502/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16502/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16502/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16502/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16502/index.html

@Youssef1313
Copy link
Member Author

Revised screenshot comparison and it's all good.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16502/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16502/index.html

@Youssef1313 Youssef1313 enabled auto-merge May 2, 2024 21:36
@Youssef1313 Youssef1313 merged commit 74e7347 into unoplatform:master May 3, 2024
103 checks passed
@Youssef1313 Youssef1313 deleted the skia-clipping branch May 3, 2024 05:26
ramezgerges added a commit to ramezgerges/uno that referenced this pull request May 3, 2024
@ramezgerges
chore: undo changes from unoplatform#16502
6d4ee55
ramezgerges added a commit to ramezgerges/uno that referenced this pull request May 3, 2024
@ramezgerges
chore: add back changes from unoplatform#16502
e0a3205
ramezgerges added a commit to ramezgerges/uno that referenced this pull request May 3, 2024
@ramezgerges
chore: add back changes from unoplatform#16502
76e726d
ramezgerges added a commit to ramezgerges/uno that referenced this pull request May 4, 2024
@ramezgerges
chore: add back changes from unoplatform#16502
fc767b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr1rrb dr1rrb dr1rrb approved these changes

@MartinZikmund MartinZikmund Awaiting requested review from MartinZikmund

Assignees
No one assigned
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transform_Ellipse_in_two_grids doesn't render correctly on Skia
3 participants
@Youssef1313 @unodevops @dr1rrb