Fix potential github action smells #16508
Conversation
|
|
|
@ceddy4395 also note we're using conventional commits, you'll need to rewrite your commits using this convention (see the PR template). |
- Stop running workflows when there is a newer commit in branch - Use commit hash instead of tags for action versions - Use names for run steps - Steps should only perform a single command
|
@jeromelaban, thanks for pointing that out 馃檲 |
|
馃 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html |
|
@ceddy4395 it looks like specifying the base path entirely is required: https://github.com/unoplatform/uno/actions/runs/8906593863/job/24459818384?pr=16508#step:14:49 |
|
@jeromelaban Yes I see, thanks for the feedback, I've reverted those changes. |
|
馃 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html |
| - name: Convert source tree to UWP | ||
| run: | | ||
| cd $env:GITHUB_WORKSPACE\src\Uno.WinUIRevert | ||
| dotnet run "$env:GITHUB_WORKSPACE" | ||
|
|
||
| - name: Run API Sync Tool | ||
| working-directory: \build |
There was a problem hiding this comment.
I think this should be removed
There was a problem hiding this comment.
Ah yes I forgot! Removed it now
working-dir Make sure all files (including new ones) are also staged
|
馃 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html |
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Hey! 馃檪
I want to contribute the following changes to your workflow:
These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):