Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Move build to net8.0/net9.0 instead of net8.0/net7.0 #16523

Merged
merged 56 commits into from
May 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
0fa1d69
build: Move build to net8.0/net9.0 instead of net8.0/net7.0
Youssef1313 Apr 30, 2024
0ef171f
chore: Few more adjustments
Youssef1313 Apr 30, 2024
8fa3bfe
chore: Adjust
Youssef1313 Apr 30, 2024
7c69796
chore: Adjust
Youssef1313 Apr 30, 2024
aed1754
chore: Adjust
Youssef1313 Apr 30, 2024
c3bb5cb
chore: Progress
Youssef1313 Apr 30, 2024
ebf7430
chore: Adjust
Youssef1313 Apr 30, 2024
1df1d8f
chore: Progress
Youssef1313 Apr 30, 2024
0b9b0a9
chore: Adjust
Youssef1313 Apr 30, 2024
e3a6a6a
chore: Adjust
Youssef1313 Apr 30, 2024
997199a
chore: Adjust
Youssef1313 Apr 30, 2024
fa3a22b
chore: Adjust for iOS
Youssef1313 Apr 30, 2024
b761371
chore: Adjust
Youssef1313 Apr 30, 2024
17a12e9
chore: Adjust
Youssef1313 Apr 30, 2024
6d0c8ad
chore: Adjust
Youssef1313 Apr 30, 2024
75cf159
chore: Adjust
Youssef1313 Apr 30, 2024
6c44b7b
chore: Adjust
Youssef1313 Apr 30, 2024
5237543
chore: net7 for iOS
Youssef1313 May 1, 2024
a0fe227
chore: Adjust for iOS
Youssef1313 May 1, 2024
6374a72
chore: Adjust
Youssef1313 May 1, 2024
843f26a
chore: Fix typo
Youssef1313 May 1, 2024
13c1c1e
chore: Adjust
Youssef1313 May 1, 2024
cbd1209
chore: switch back to MSBuild
Youssef1313 May 1, 2024
c3986f7
chore: Adjust
Youssef1313 May 1, 2024
f5916c9
chore: Adjust
Youssef1313 May 1, 2024
4245187
chore: UseRidGraph
Youssef1313 May 1, 2024
dd1f5f7
chore: Adjust iOS
Youssef1313 May 1, 2024
0294b60
chore: Adjust
Youssef1313 May 1, 2024
6bce7c0
chore: Small fix
Youssef1313 May 1, 2024
18b5435
chore: Adjust
Youssef1313 May 1, 2024
cc75ff6
chore: Adjust
Youssef1313 May 1, 2024
fd891ab
chore: Adjust
Youssef1313 May 2, 2024
ce3afa4
chore: Adjust
Youssef1313 May 2, 2024
3dd72fc
chore: Adjust
Youssef1313 May 2, 2024
2372c82
chore: Adjust for Windows build
Youssef1313 May 12, 2024
fddc72f
chore: Adjust Windows build
Youssef1313 May 12, 2024
36cf4cd
chore: Adjust for WinAppSDK build
Youssef1313 May 12, 2024
ce58788
chore: Adjust RC global json
Youssef1313 May 12, 2024
108a5d0
chore: Adjust for SG unit tests
Youssef1313 May 12, 2024
048ec0e
chore: Adjust for WinAppSDK build
Youssef1313 May 12, 2024
3209bb0
chore: Adjust for WinAppSDK
Youssef1313 May 13, 2024
a215257
chore: Adjust template tests
Youssef1313 May 13, 2024
bb204fe
chore: Adjust for template tests
Youssef1313 May 13, 2024
e07dca1
chore: Adjust template tests for WinAppSDK
Youssef1313 May 13, 2024
c4c1ff1
chore: Publish binlogs
Youssef1313 May 13, 2024
426867d
chore: Adjust for WinAppSDK RID change
Youssef1313 May 13, 2024
f136da5
chore: Produce more binlogs
Youssef1313 May 14, 2024
63445eb
chore: Adjust
Youssef1313 May 15, 2024
6df9431
chore: Adjust
Youssef1313 May 15, 2024
601a3d7
chore: Run tests using .NET 8 SDK
Youssef1313 May 16, 2024
f33c362
chore: Address review comments
Youssef1313 May 17, 2024
d9bdd85
chore: Adjust for macOS
Youssef1313 May 17, 2024
443b03c
chore: Adjust
Youssef1313 May 17, 2024
c77d837
chore: Adjust gen
Youssef1313 May 17, 2024
a31ad1c
chore: Adjust
Youssef1313 May 17, 2024
d9b2cbd
chore: Small fix
Youssef1313 May 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/uwp-autoconvert.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ on:

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
UnoCheck_Version: '1.18.1'
UnoCheck_Manifest: 'https://raw.githubusercontent.com/unoplatform/uno.check/3728e150e4e148789302dcc00baaeae63e0c7eae/manifests/uno.ui.manifest.json'
UnoCheck_Version: '1.20.2'
UnoCheck_Manifest: 'https://raw.githubusercontent.com/unoplatform/uno.check/bd121b30a0044fd80df18618dd7915fe8ccf4503/manifests/uno.ui.manifest.json'

# Only convert using NetPrevious
UnoDisableNetCurrentMobile: true
Expand All @@ -29,7 +29,7 @@ jobs:

- name: Pin .NET Version
run: |
cp build/ci/net7/global.json global.json
cp build/ci/net8/global.json global.json

- name: Setup .NET SDK
uses: actions/setup-dotnet@v3
Expand Down
16 changes: 8 additions & 8 deletions build/Uno.UI.Build.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<Target Name="BuildCIReference">

<MSBuild
Properties="Configuration=Release;InformationalVersion=$(GITVERSION_InformationalVersion);CI_Build=true;IS_NET7_BUILD=true;_IsCIBuild=true;PackageOutputPath=$(BUILD_ARTIFACTSTAGINGDIRECTORY)\vslatest-skia;PackageVersion=$(GITVERSION_SemVer)"
Properties="Configuration=Release;InformationalVersion=$(GITVERSION_InformationalVersion);CI_Build=true;_IsCIBuild=true;PackageOutputPath=$(BUILD_ARTIFACTSTAGINGDIRECTORY)\vslatest-skia;PackageVersion=$(GITVERSION_SemVer)"
Projects="filters\Uno.UI-packages-reference.slnf"
Targets="Restore;Build"
RebaseOutputs="false"
Expand All @@ -132,9 +132,9 @@
<MSBuild Properties="Configuration=Release;Platform=x86" Projects="..\src\Uno.UWPSyncGenerator.Reference\Uno.UWPSyncGenerator.Reference.csproj" Targets="Build" />

<ItemGroup>
<MixinTargetFrameworks Include="net7.0-ios" />
<MixinTargetFrameworks Include="net7.0-android" />
<MixinTargetFrameworks Include="net7.0-macos" />
<MixinTargetFrameworks Include="net8.0-ios17.0" />
<MixinTargetFrameworks Include="net8.0-android" />
<MixinTargetFrameworks Include="net8.0-macos14.0" />
</ItemGroup>

<MSBuild
Expand Down Expand Up @@ -302,12 +302,12 @@
<!-- Adjust build props file for Windows targets -->
<XmlPoke XmlInputPath=".\nuget\Uno.WinUI.nuspec" Query="/x:package/x:files/x:file[@target='buildTransitive\uap10.0.16299\uno.winui.props']/@target" Value="buildTransitive\uap10.0.16299\$(PackageNamePrefix).props" Namespaces="$(NugetNamespace)" Condition="'$(UNO_UWP_BUILD)'=='true'"/>
<XmlPoke XmlInputPath=".\nuget\Uno.WinUI.nuspec" Query="/x:package/x:files/x:file[@target='buildTransitive\uap10.0.19041\uno.winui.props']/@target" Value="buildTransitive\uap10.0.19041\$(PackageNamePrefix).props" Namespaces="$(NugetNamespace)" Condition="'$(UNO_UWP_BUILD)'=='true'"/>
<XmlPoke XmlInputPath=".\nuget\Uno.WinUI.nuspec" Query="/x:package/x:files/x:file[@target='buildTransitive\net7.0-windows\uno.winui.props']/@target" Value="buildTransitive\net7.0-windows\$(PackageNamePrefix).props" Namespaces="$(NugetNamespace)" Condition="'$(UNO_UWP_BUILD)'=='true'"/>
<XmlPoke XmlInputPath=".\nuget\Uno.WinUI.nuspec" Query="/x:package/x:files/x:file[@target='buildTransitive\net8.0-windows\uno.winui.props']/@target" Value="buildTransitive\net8.0-windows\$(PackageNamePrefix).props" Namespaces="$(NugetNamespace)" Condition="'$(UNO_UWP_BUILD)'=='true'"/>

<!-- Adjust build targets file for Windows targets -->
<XmlPoke XmlInputPath=".\nuget\Uno.WinUI.nuspec" Query="/x:package/x:files/x:file[@target='buildTransitive\uap10.0.16299\uno.winui.targets']/@target" Value="buildTransitive\uap10.0.16299\$(PackageNamePrefix).targets" Namespaces="$(NugetNamespace)" Condition="'$(UNO_UWP_BUILD)'=='true'"/>
<XmlPoke XmlInputPath=".\nuget\Uno.WinUI.nuspec" Query="/x:package/x:files/x:file[@target='buildTransitive\uap10.0.19041\uno.winui.targets']/@target" Value="buildTransitive\uap10.0.19041\$(PackageNamePrefix).targets" Namespaces="$(NugetNamespace)" Condition="'$(UNO_UWP_BUILD)'=='true'"/>
<XmlPoke XmlInputPath=".\nuget\Uno.WinUI.nuspec" Query="/x:package/x:files/x:file[@target='buildTransitive\net7.0-windows\uno.winui.targets']/@target" Value="buildTransitive\net7.0-windows\$(PackageNamePrefix).targets" Namespaces="$(NugetNamespace)" Condition="'$(UNO_UWP_BUILD)'=='true'"/>
<XmlPoke XmlInputPath=".\nuget\Uno.WinUI.nuspec" Query="/x:package/x:files/x:file[@target='buildTransitive\net8.0-windows\uno.winui.targets']/@target" Value="buildTransitive\net8.0-windows\$(PackageNamePrefix).targets" Namespaces="$(NugetNamespace)" Condition="'$(UNO_UWP_BUILD)'=='true'"/>

<!-- Skia GTK targets/props-->
<Move SourceFiles=".\nuget\Uno.WinUI.Skia.Gtk.targets" DestinationFiles=".\nuget\$(PackageNamePrefix).Skia.Gtk.targets" Condition="'$(UNO_UWP_BUILD)'=='true'"/>
Expand Down Expand Up @@ -388,14 +388,14 @@
<NuSpecProperties>NoWarn=NU5100,NU5105,NU5131;branch=$(GITVERSION_BranchName);commitid=$(GitVersion_Sha)</NuSpecProperties>

<NuSpecProperties Condition="'$(UNO_UWP_BUILD)'=='true'">$(NuSpecProperties);winuisourcepath=uap10.0.19041;winuitargetpath=UAP</NuSpecProperties>
<NuSpecProperties Condition="'$(UNO_UWP_BUILD)'!='true'">$(NuSpecProperties);winuisourcepath=net7.0-windows10.0.19041.0;winuitargetpath=net7.0-windows10.0.19041.0</NuSpecProperties>
<NuSpecProperties Condition="'$(UNO_UWP_BUILD)'!='true'">$(NuSpecProperties);winuisourcepath=net8.0-windows10.0.19041.0;winuitargetpath=net8.0-windows10.0.19041.0</NuSpecProperties>
</PropertyGroup>

<!-- Pre-validation of contents to be packed -->
<Error Text="The Uno.UI.Toolkit PRI file is not present in src\Uno.UI.Toolkit\bin\Uno.UI.Toolkit.Windows\Release"
Condition="'$(UNO_UWP_BUILD)'=='true' and !exists('..\src\Uno.UI.Toolkit\bin\Uno.UI.Toolkit.Windows\Release\uap10.0.19041\Uno.UI.Toolkit.pri')" />
<Error Text="The Uno.UI.Toolkit PRI file is not present in src\Uno.UI.Toolkit\bin\Uno.UI.Toolkit.Windows\Release"
Condition="'$(UNO_UWP_BUILD)'!='true' and !exists('..\src\Uno.UI.Toolkit\bin\Uno.UI.Toolkit.Windows\Release\net7.0-windows10.0.19041.0\Uno.UI.Toolkit.pri')" />
Condition="'$(UNO_UWP_BUILD)'!='true' and !exists('..\src\Uno.UI.Toolkit\bin\Uno.UI.Toolkit.Windows\Release\net8.0-windows10.0.19041.0\Uno.UI.Toolkit.pri')" />

<!-- Create the packages -->
<Exec Command="$(NuGetBin) pack nuget\Uno.WinUI.nuspec -Verbosity Detailed -Version &quot;$(GITVERSION_SemVer)&quot; -Properties &quot;$(NuSpecProperties)&quot;" />
Expand Down
18 changes: 9 additions & 9 deletions build/ci/.azure-devops-android-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- checkout: self
clean: true

- template: templates/dotnet7-mobile-install-mac.yml
- template: templates/dotnet-mobile-install-mac.yml

- template: templates/nuget-cache.yml
parameters:
Expand All @@ -51,12 +51,12 @@ jobs:

- bash: |
cd $(build.sourcesdirectory)/src/SamplesApp/SamplesApp.netcoremobile
dotnet publish -f net7.0-android -c Release -p:UnoTargetFrameworkOverride=net7.0-android /bl:$(build.artifactstagingdirectory)/android-netcoremobile-sampleapp.binlog
dotnet publish -f net8.0-android -c Release -p:UnoTargetFrameworkOverride=net8.0-android /bl:$(build.artifactstagingdirectory)/android-netcoremobile-sampleapp.binlog
displayName: Build Android samples app

- task: CopyFiles@2
inputs:
SourceFolder: $(build.sourcesdirectory)/src/SamplesApp/SamplesApp.netcoremobile/bin/Release/net7.0-android/publish
SourceFolder: $(build.sourcesdirectory)/src/SamplesApp/SamplesApp.netcoremobile/bin/Release/net8.0-android/publish
Contents: 'uno.platform.unosampleapp-Signed.apk'
TargetFolder: $(build.artifactstagingdirectory)/android
CleanTargetFolder: false
Expand Down Expand Up @@ -95,35 +95,35 @@ jobs:
# UITEST_TEST_MODE_NAME: Automated

${{ each testBucket in parameters.automatedTestsBuckets }}:
Android_9.0_Group_${{ testBucket }}_net7:
Android_9.0_Group_${{ testBucket }}_net8:
ANDROID_SIMULATOR_APILEVEL: 28
UITEST_TEST_MODE_NAME: Automated
UNO_UITEST_BUCKET_ID: ${{ testBucket }} ## Note: Align with UNO_UITEST_BUCKET_COUNT
SAMPLEAPP_ARTIFACT_NAME: uitests-android-netcoremobile-build
TARGETPLATFORM_NAME: net7
TARGETPLATFORM_NAME: net8
FAILBUILD_ON_FAILURE: true
ALLOW_RERUN: true
UITEST_TEST_TIMEOUT: '270s'

${{ each testGroup in parameters.runtimeTestsGroups }}:
Android_9.0_RuntimeTests_${{ testGroup }}_net7:
Android_9.0_RuntimeTests_${{ testGroup }}_net8:
ANDROID_SIMULATOR_APILEVEL: 28
UITEST_TEST_MODE_NAME: RuntimeTests
UNO_UITEST_BUCKET_ID: RuntimeTests
UITEST_RUNTIME_TEST_GROUP: ${{ testGroup }}
UITEST_RUNTIME_TEST_GROUP_COUNT: 5
SAMPLEAPP_ARTIFACT_NAME: uitests-android-netcoremobile-build
TARGETPLATFORM_NAME: net7
TARGETPLATFORM_NAME: net8
FAILBUILD_ON_FAILURE: true
ALLOW_RERUN: false
UITEST_TEST_TIMEOUT: '2600s'

Android_9.0_Snapshots_net7:
Android_9.0_Snapshots_net8:
ANDROID_SIMULATOR_APILEVEL: 28
UITEST_TEST_MODE_NAME: Snapshots
UNO_UITEST_BUCKET_ID: Snapshots
SAMPLEAPP_ARTIFACT_NAME: uitests-android-netcoremobile-build
TARGETPLATFORM_NAME: net7
TARGETPLATFORM_NAME: net8
FAILBUILD_ON_FAILURE: true
ALLOW_RERUN: true
UITEST_TEST_TIMEOUT: '270s'
Expand Down
4 changes: 3 additions & 1 deletion build/ci/.azure-devops-ios-tests-run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
artifactName: uitests-failure-results
downloadPath: '$(build.sourcesdirectory)/build'

- template: templates/dotnet-install.yml
- template: templates/dotnet7-mobile-install-mac.yml

- template: templates/nuget-cache.yml
parameters:
Expand Down Expand Up @@ -95,6 +95,7 @@ jobs:
UITEST_RUNTIME_TEST_GROUP_COUNT: "${{ parameters.UITEST_RUNTIME_TEST_GROUP_COUNT }}"
UITEST_TEST_TIMEOUT: "${{ parameters.UITEST_TEST_TIMEOUT }}"
UNO_UITEST_IOSBUNDLE_PATH: "$(build.sourcesdirectory)/build/ios-uitest-build/SamplesApp.app"
UnoTargetFrameworkOverride: "net7.0-ios"

- task: PublishTestResults@2
condition: always()
Expand Down Expand Up @@ -124,6 +125,7 @@ jobs:
UITEST_RUNTIME_TEST_GROUP_COUNT: "${{ parameters.UITEST_RUNTIME_TEST_GROUP_COUNT }}"
UITEST_TEST_TIMEOUT: "${{ parameters.UITEST_TEST_TIMEOUT }}"
UNO_UITEST_IOSBUNDLE_PATH: "$(build.sourcesdirectory)/build/ios-uitest-build/SamplesApp.app"
UnoTargetFrameworkOverride: "net7.0-ios"

- task: PublishTestResults@2
condition: eq(variables.UITEST_ALLOW_RERUN, 'true')
Expand Down
1 change: 0 additions & 1 deletion build/ci/.azure-devops-ios-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ jobs:
-r:ios-arm64 \
-p:BuildForTestFlight=true \
-p:UnoTargetFrameworkOverride=net7.0-ios \
-p:UnoUIDisableNet8Build=true \
/bl:$(build.artifactstagingdirectory)/ios-netcoremobile-sampleapp-testflight.binlog

displayName: Build iOS App for TestFlight
Expand Down
6 changes: 3 additions & 3 deletions build/ci/.azure-devops-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- checkout: self
clean: true

- template: templates/dotnet7-mobile-install-mac.yml
- template: templates/dotnet-mobile-install-mac.yml

- template: templates/nuget-cache.yml
parameters:
Expand All @@ -37,13 +37,13 @@ jobs:

- script: |
cd src/SamplesApp/SamplesApp.netcoremobile
dotnet build -f net7.0-macos -r osx-x64 -c Release -p:UnoTargetFrameworkOverride=net7.0-macos -p:CreatePackage=true -p:EnableCodeSigning=false /bl:$BUILD_ARTIFACTSTAGINGDIRECTORY/macos-netcoremobile-sampleapp.binlog
dotnet build -r osx-x64 -c Release -p:UnoTargetFrameworkOverride=net8.0-macos -p:CreatePackage=true -p:EnableCodeSigning=false /bl:$BUILD_ARTIFACTSTAGINGDIRECTORY/macos-netcoremobile-sampleapp.binlog
displayName: 'Build Sample app'

- task: CopyFiles@2
displayName: 'Copy macOS artifacts'
inputs:
SourceFolder: $(build.sourcesdirectory)/src/SamplesApp/SamplesApp.netcoremobile/bin/Release/net7.0-macos/osx-x64
SourceFolder: $(build.sourcesdirectory)/src/SamplesApp/SamplesApp.netcoremobile/bin/Release/net8.0-macos14.0/osx-x64
Contents: '**/*.pkg'
TargetFolder: $(build.artifactstagingdirectory)
CleanTargetFolder: false
Expand Down
10 changes: 5 additions & 5 deletions build/ci/.azure-devops-package-netcoremobile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ jobs:

strategy:
matrix:
NET8:
NET9:
UnoDisableNetPreviousMobile: true
ZipFileTargetFramework: net8
ZipFileTargetFramework: net9

NET7:
NET8:
UnoDisableNetCurrentMobile: true
UnoDisableNetCurrent: true
ZipFileTargetFramework: net7
ZipFileTargetFramework: net8

variables:
CombinedConfiguration: Release|Any CPU
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
restoreNugetPackages: false
logProjectEvents: false
createLogFile: false
condition: and(succeeded(), eq(variables['ZipFileTargetFramework'], 'net7'))
condition: and(succeeded(), eq(variables['ZipFileTargetFramework'], 'net8'))
displayName: Building WinAppSDK/UWP package binaries

- template: templates/copy-package-assets.yml
Expand Down
33 changes: 30 additions & 3 deletions build/ci/.azure-devops-project-template-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ jobs:
- Generate_Packages

variables:
UnoDisableNetPreviousMobile: true
UnoDisableNetCurrentMobile: true
UnoDisableNetCurrent: true

steps:
- task: DownloadBuildArtifacts@0
Expand All @@ -40,6 +41,14 @@ jobs:
BUILD_SOURCESDIRECTORY: $(BUILD.SOURCESDIRECTORY)
GITVERSION_SemVer: $(GITVERSION.SemVer)

- task: PublishBuildArtifacts@1
retryCountOnTaskFailure: 3
condition: always()
inputs:
PathtoPublish: $(build.sourcesdirectory)/src/SolutionTemplate/binlogs
ArtifactName: template-tests-binlogs-windows
ArtifactType: Container

- job: Dotnet_Template_Tests_NetCoreMobile_macos
displayName: 'Run .NET Templates Tests macOS'
timeoutInMinutes: 90
Expand All @@ -51,7 +60,8 @@ jobs:
- Generate_Packages

variables:
UnoDisableNetPreviousMobile: true
UnoDisableNetCurrent: true
UnoDisableNetCurrentMobile: true

steps:
- task: DownloadBuildArtifacts@0
Expand Down Expand Up @@ -80,14 +90,23 @@ jobs:
BUILD_SOURCESDIRECTORY: $(BUILD.SOURCESDIRECTORY)
GITVERSION_SemVer: $(GITVERSION.SemVer)

- task: PublishBuildArtifacts@1
retryCountOnTaskFailure: 3
condition: always()
inputs:
PathtoPublish: $(build.sourcesdirectory)/src/SolutionTemplate/binlogs
ArtifactName: template-tests-binlogs-macos
ArtifactType: Container

- job: Dotnet_Template_Tests_net7_Linux
displayName: 'Run dotnet new Templates Tests - Linux (net7)'

dependsOn:
- Generate_Packages

variables:
UnoDisableNetPreviousMobile: true
UnoDisableNetCurrent: true
UnoDisableNetCurrentMobile: true

pool: ${{ parameters.vmPoolLinux }}

Expand Down Expand Up @@ -116,3 +135,11 @@ jobs:
env:
BUILD_SOURCESDIRECTORY: $(BUILD.SOURCESDIRECTORY)
GITVERSION_SemVer: $(GITVERSION.SemVer)

- task: PublishBuildArtifacts@1
retryCountOnTaskFailure: 3
condition: always()
inputs:
PathtoPublish: $(build.sourcesdirectory)/src/SolutionTemplate/binlogs
ArtifactName: template-tests-binlogs-net7-linux
ArtifactType: Container
8 changes: 4 additions & 4 deletions build/ci/.azure-devops-skia-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
retryCountOnTaskFailure: 3
condition: always()
inputs:
PathtoPublish: $(Build.SourcesDirectory)\src\SamplesApp\SamplesApp.Skia.Gtk\bin\Release\net7.0
PathtoPublish: $(Build.SourcesDirectory)\src\SamplesApp\SamplesApp.Skia.Gtk\bin\Release\net8.0
ArtifactName: skia-gtk-samples-app-$(XAML_FLAVOR_BUILD)
ArtifactType: Container

Expand All @@ -66,18 +66,18 @@ jobs:
retryCountOnTaskFailure: 3
condition: always()
inputs:
PathtoPublish: $(Build.SourcesDirectory)\src\SamplesApp\UnoIslandsSamplesApp.Skia.WPF\bin\Release\net7.0-windows
PathtoPublish: $(Build.SourcesDirectory)\src\SamplesApp\UnoIslandsSamplesApp.Skia.WPF\bin\Release\net8.0-windows
ArtifactName: uno-islands-skia-wpf-samples-app-$(XAML_FLAVOR_BUILD)
ArtifactType: Container

- powershell: dotnet publish src/SamplesApp/SamplesApp.Skia.Generic/SamplesApp.Skia.Generic.csproj -c Release -f net7.0 /bl:$(build.artifactstagingdirectory)\build-x11.binlog
- powershell: dotnet publish src/SamplesApp/SamplesApp.Skia.Generic/SamplesApp.Skia.Generic.csproj -c Release -f net8.0 /bl:$(build.artifactstagingdirectory)\build-x11.binlog
displayName: Build Generic Skia Head

- task: PublishBuildArtifacts@1
retryCountOnTaskFailure: 3
condition: always()
inputs:
PathtoPublish: $(Build.SourcesDirectory)\src\SamplesApp\SamplesApp.Skia.Generic\bin\Release\net7.0
PathtoPublish: $(Build.SourcesDirectory)\src\SamplesApp\SamplesApp.Skia.Generic\bin\Release\net8.0
ArtifactName: skia-generic-samples-app-$(XAML_FLAVOR_BUILD)
ArtifactType: Container

Expand Down
14 changes: 11 additions & 3 deletions build/ci/.azure-devops-wasdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
pool: ${{ parameters.poolName }}

variables:
CombinedConfiguration: Release|Any CPU
CombinedConfiguration: Release|AnyCPU
CI_Build: true

# Use pre-defined local nuget cache for restore
Expand Down Expand Up @@ -37,7 +37,15 @@ jobs:
msbuildLocationMethod: version
msbuildVersion: latest
msbuildArchitecture: x86
msbuildArguments: /r /t:Publish /m /v:m /p:Configuration=Release /p:RuntimeIdentifier=win10-x64 /p:GenerateAppxPackageOnBuild=true /detailedsummary /bl:$(build.artifactstagingdirectory)/build-wasdk.binlog
# Using x64 to workaround this error:
# ---
# Microsoft.Build.Msix.Packaging.targets(1036,5): Error : Packaged .NET applications with an
# app host exe cannot be ProcessorArchitecture neutral. Please specify a RuntimeIdentifier
# or a Platform other than AnyCPU.
# ---
# NOTE: The error says to specify a RuntimeIdentifier *OR* platform other than AnyCPU.
# We already specify RuntimeIdentifier=win-x64 in the build below. Still, the error pops up.
msbuildArguments: /r /t:Publish /m /v:m /p:Configuration=Release /p:Platform=x64 /p:RuntimeIdentifier=win-x64 /p:GenerateAppxPackageOnBuild=true /detailedsummary /bl:$(build.artifactstagingdirectory)/build-wasdk.binlog
clean: false
restoreNugetPackages: false
logProjectEvents: false
Expand All @@ -46,7 +54,7 @@ jobs:
- task: CopyFiles@2
condition: always()
inputs:
SourceFolder: $(build.sourcesdirectory)/src/SamplesApp/SamplesApp.Windows/bin/Release/net7.0-windows10.0.19041.0/win10-x64/AppPackages
SourceFolder: $(build.sourcesdirectory)/src/SamplesApp/SamplesApp.Windows/bin/x64/Release/net8.0-windows10.0.19041.0/win-x64/AppPackages
Contents: '**'
TargetFolder: $(build.artifactstagingdirectory)
CleanTargetFolder: false
Expand Down
Loading
Loading