Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TimePicker): Make sure iOS flyout opens #4812

Merged
merged 1 commit into from
Jan 12, 2021
Merged

fix(TimePicker): Make sure iOS flyout opens #4812

merged 1 commit into from
Jan 12, 2021

Conversation

iosub
Copy link
Contributor

@iosub iosub commented Dec 30, 2020

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

On iOS the flyout of the TimePicker does not open

What is the new behavior?

Make sure iOS flyout opens

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@iosub iosub requested a review from a team December 30, 2020 15:18
@gitpod-io
Copy link

gitpod-io bot commented Dec 30, 2020

@iosub
Copy link
Contributor Author

iosub commented Dec 30, 2020

@MartinZikmund I hope this time is ok :-)

@iosub iosub mentioned this pull request Dec 30, 2020
Closed
6 tasks
MartinZikmund
MartinZikmund approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@MartinZikmund MartinZikmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

src/Uno.UI/UI/Xaml/Controls/TimePicker/TimePickerSelector.iOS.cs Show resolved Hide resolved
@davidjohnoliver
Copy link
Contributor

Does this address #4611 ? cc @ajpinedam

@iosub
Copy link
Contributor Author

iosub commented Jan 8, 2021

Does this address #4611 ? cc @ajpinedam

macOS.10.14.Nuevo.-.VMware.Workstation.2021-01-08.23-33-57.mp4

Yes It does

@ajpinedam
Copy link
Contributor

Does this address #4611 ? cc @ajpinedam

@davidjohnoliver no, unfortunately, this fix another issue but 4611 is still present

@ajpinedam ajpinedam merged commit d4912c5 into unoplatform:master Jan 12, 2021
@welcome
Copy link

welcome bot commented Jan 12, 2021

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

@iosub
Copy link
Contributor Author

iosub commented Jan 12, 2021

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Thanks for your Great Work!!

@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/3.1

@mergify mergify bot mentioned this pull request Feb 18, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2021

Command backport release/stable/3.1: success

Backports have been created

jeromelaban added a commit that referenced this pull request Feb 19, 2021
@jeromelaban
Merge pull request #5273 from unoplatform/mergify/bp/release/stable/3…
c085945 
….1/pr-4812

fix(TimePicker): Make sure iOS flyout opens (bp #4812)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iosub @davidjohnoliver @ajpinedam @jeromelaban @MartinZikmund