New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Skia): [WPF] Issue #7829 SynchronizationContext #7840
fix(Skia): [WPF] Issue #7829 SynchronizationContext #7840
Conversation
Can anyone review this PR? |
a745464
to
a64b743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be8b1e4
to
7af534a
Compare
If run in test it works as expected but if run in Real Test APP the issue is present. I have tryed with 4.1.0-dev.461. |
It would be important to understand what's different in the sample app, it's supposed to behavior the same way. Can you add the test in the runtime tests and see what results you're getting ? |
I try. How can I do to indicate that the test must be performed only in wpf? I need to create a real WPF window and call event a via the window API. |
The test should theoretically work on all platforms, but if we need to limit it to Skia, we'll be able to. Can you add it and launch a build? We'll see how far it goes :) |
c08f893
to
0b7557b
Compare
0b7557b
to
68937be
Compare
…nchronizationContext when input event is called.
68937be
to
096eaf5
Compare
@jeromelaban Is there some way to the test could avoid requiring separate runtime test project for WPF specifically 🤔 ? (it does not seem so based on the fact the test needs to access |
I don't think it's necessary at this point. The test that requires a window to validate, this feels like a too low-level replacement for a UI test engine that would do this in a generic way. The solution to override the synchronization context for all event going out seems a bit too wide as well, particularly if it's about events going out of Uno's APIs, for which the entry point is known. Let's change those entry points for now to set the proper synchronization context. We can create a test that uses the new pointer injection to validate that we get the proper synchronization context out inside of uno pointer or generic input handlers. |
GitHub Issue (If applicable): closes #7829
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):