New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST Reference Resolution Improvements && AST Yul FunctionCall Nil Fix #128

Merged

0x19 merged 1 commit into main from ast/reference-fix

Oct 18, 2023

Contributor

0x19 commented Oct 18, 2023

Basically few issues resolved with this fix:

UpdateReferenceById() in AST did not take under consideration GlobalNodes. It's sorted now.
AST Yul GetNode() did not have all YulIdentifiers applied.
AST YulFunctionCall did not take under consideration YulIdentifier resulting in GetNodes() having a nil item, resulting in panics across the board.


          AST Reference Resolution Improvements && AST Yul FunctionCall Nil Fix

b363d5e

0x19 added bug ast labels

0x19 self-assigned this

0x19 merged commit 744d0cd into main

5 of 8 checks passed

0x19 deleted the ast/reference-fix branch

October 18, 2023 07:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ast bug