fix(cache): imporove cache performance and resolve cache mistake #344

lishaobos · 2023-03-09T06:19:42Z

Resolve

when code does not need auto inject api and relevant cache should be removed.
imporove cache performance and resolve mistake cause by race condition.

lishaobos · 2023-03-09T06:20:06Z

src/core/ctx.ts

@@ -206,11 +208,11 @@ ${dts}`.trim()}\n`

    const res = await unimport.injectImports(s, id)

+    await updateCacheImports(id, res.imports)


is point one!

lishaobos · 2023-03-09T06:22:08Z

src/core/ctx.ts

    await unimport.modifyDynamicImports(async (imports) => {
-      const cacheData = await getCacheData(cachePath)


cache data does not need alwawys read

lishaobos · 2023-03-09T06:23:09Z

src/core/ctx.ts

      if (id && importList) {
        const filePath = posix.normalize(posix.relative(root, id))
        importList = importList.filter(i => (i.name ?? i.as) && i.name !== 'default')
        if (importList.length)
          cacheData[filePath] = importList
        else
          delete cacheData[filePath]
-        await writeFile(cachePath, JSON.stringify(cacheData, null, 2))
+        writeFileThrottled(cachePath, JSON.stringify(cacheData, null, 2))


write file need add throttle

fix(cache): imporove cache performance and resolve cache mistake

29d4051

lishaobos commented Mar 9, 2023

View reviewed changes

antfu merged commit c5a5fcc into unplugin:main Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cache): imporove cache performance and resolve cache mistake #344

fix(cache): imporove cache performance and resolve cache mistake #344

lishaobos commented Mar 9, 2023 •

edited

lishaobos Mar 9, 2023

lishaobos Mar 9, 2023

lishaobos Mar 9, 2023

		@@ -206,11 +208,11 @@ ${dts}`.trim()}\n`

		const res = await unimport.injectImports(s, id)

		await updateCacheImports(id, res.imports)

		await unimport.modifyDynamicImports(async (imports) => {
		const cacheData = await getCacheData(cachePath)

fix(cache): imporove cache performance and resolve cache mistake #344

fix(cache): imporove cache performance and resolve cache mistake #344

Conversation

lishaobos commented Mar 9, 2023 • edited

Resolve

lishaobos Mar 9, 2023

Choose a reason for hiding this comment

lishaobos Mar 9, 2023

Choose a reason for hiding this comment

lishaobos Mar 9, 2023

Choose a reason for hiding this comment

lishaobos commented Mar 9, 2023 •

edited