Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add local package preset support #451

Merged
merged 5 commits into from
Dec 3, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented Nov 26, 2023

Description

We cannot use package presets, it seems we removed the presets option.

This PR includes:

  • add packagePresets options to allow use local installed packages as presets
  • add test to dts test using magic-string
  • add example using detect-browser-es package in examples/vite-svelte, check readme

About the note in the readme, check Additonal context below.

Linked Issues

related to issue #446 and PR #450

Additional context

@mdi/js is not working, mlly unable to extract module exports, it resolves to cjs and returns an empty array: tested on my local in Svelte (type module) example:

imagen

imagen

Copy link

stackblitz bot commented Nov 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@userquin userquin changed the title feat: add packages preset support feat: add local package preset support Nov 26, 2023
@userquin userquin requested a review from antfu November 27, 2023 12:16
src/types.ts Outdated Show resolved Hide resolved
@antfu antfu merged commit a2e9095 into main Dec 3, 2023
6 checks passed
@antfu antfu deleted the userquin/feat-add-package-presets-support branch December 3, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants