Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preset): pinia and vuex presets #60

Merged
merged 1 commit into from
Oct 9, 2021
Merged

feat(preset): pinia and vuex presets #60

merged 1 commit into from
Oct 9, 2021

Conversation

userquin
Copy link
Member

@userquin userquin commented Oct 9, 2021 •
edited

closes #52
closes #58

@userquin userquin requested a review from antfu October 9, 2021 17:26
@userquin
Copy link
Member Author

userquin commented Oct 9, 2021

@antfu should we add the types/interfaces for both stores?

/cc @posva maybe you're interested on this

@antfu antfu merged commit 3555672 into unplugin:main Oct 9, 2021
@antfu
Copy link
Member

antfu commented Oct 9, 2021

If it's a highly demanded request, I think we could take some time to implement the auto-register for global types.

@userquin userquin deleted the feat/add-store-presets branch October 9, 2021 18:33
@antfu antfu mentioned this pull request Oct 9, 2021
Closed
@antfu
Copy link
Member

antfu commented Oct 9, 2021

Let's continue on #61

@unplugin unplugin locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add pinia preset add vuex presets
2 participants
@userquin @antfu