Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve id when icon name includes . in icon props #324

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

userquin
Copy link
Member

Description

Splits props from id and apply normalization only to the normalized id

Linked Issues

closes #322

Additional context

Copy link

stackblitz bot commented Nov 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@antfu antfu merged commit 29fcd04 into main Nov 13, 2023
2 checks passed
@antfu antfu deleted the userquin/fix-resolve-id branch November 13, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolveId doesn't work as expected when query params contains .s
2 participants