feat(bootstrap-vue): add support for aliases and directives #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
force-pushed
the
feat/bootstrap-vue-aliases-and-directives
branch
from
d93a38b
to
c169def
Compare
|
@antfu There is no dedicated code owner for the BootstrapVue resolver, can you please have a look to this PR? |
sxzz
approved these changes
Jul 25, 2022
There was a difference in what the components.d.ts file contained between running the vite dev build (esbuild) and the vite production build (rollup) command, which was why it has been removed by a colleague. (there were imports missing in the dev build and only included if e.g. a certain component was loaded) Furthermore, we encountered some issues with e.g. bootstrap toasts afterwards. When I get the time, I'll probably reintegrate it into our project and see if the difference between the dev build and production build can be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for BootstrapVue component aliases and directives (
options.directives: boolean- default:true).The BootstrapVue resolver has also been added to the
README.mdand the list of supported resolvers has been reordered by name. I can revert these changes if I you don't want theREADME.mdupdates as part of this PR.FYI @BenediktHeinrichs - I'm curious to know why you stopped using it in the project you mentioned?