fix: lines break #156
Merged
fix: lines break #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Jun 12, 2023
src/core/transform.ts
Outdated
|
|
||
| export function shouldTransform(code: string, id: string, options?: ScriptSetupTransformOptions): boolean { | ||
| export function shouldTransform(code: string, options?: ScriptSetupTransformOptions): boolean { |
There was a problem hiding this comment.
Why do you change the signature?
没看到使用这个变量。这个是后面要用到的吗
There was a problem hiding this comment.
No, but it's not relevant to this PR. And the function is exposed, which you might consider this as a breaking change
There was a problem hiding this comment.
No, but it's not relevant to this PR. And the function is exposed, which you might consider this as a breaking change
I didn't take that into account. I've changed it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR of the original author #155
Provide unit tests
Linked Issues
Additional context