fix(docker): Add accept header for opencontainer manifest #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, this was fixed with this commit: |
|
@fabricionaweb Thanks. I wasn't even aware that the GUI was open source. I have been at work all day and I was just about to clone the repo and make a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It have been discussed in the forum as well about this. Thanks m33ts4k0z to figured out.
I went through some references and left some comments with the sources.
Im including:
application/vnd.oci.image.index.v1+jsonandapplication/vnd.oci.image.manifest.v1+jsonwhich is about opencontainersapplication/vnd.docker.distribution.manifest.v1+jsonto support v1 manifests just in case...This also resolves #1111
(previous MR had branch typo)