-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHC 9.4 #201
Conversation
This is assumed to exist. Like a network connection.
I get the feeling this is considered best practice.
Is there a more systematic way of ensuring that nothing build than monitoring the output of The patch doesn't have nix screaming at me and % nix flake check
warning: Git tree '/Users/astlouisf/un/intlc' is dirty
astlouisf@lithium intlc % echo $?
0
% nix develop
warning: Git tree '/Users/astlouisf/un/intlc' is dirty
$ which haskell-language-server-9.4.6
/nix/store/zc2hsxns5jz3jha9j5v3lp69l07mraix-haskell-language-server-2.0.0.1/bin/haskell-language-server-9.4.6 ghcup has no knowledge of ghc-9.4.6 $ ghcup list -c installed 2>/dev/null
Tool Version Tags Notes
✔✔ ghc 9.2.5 base-4.16.4.0 hls-powered
✓ ghc 9.4.4 base-4.17.0.0 hls-powered
✓ cabal 3.6.2.0 recommended
✔✔ cabal 3.8.1.0
✓ hls 1.9.0.0
✔✔ hls 1.9.1.0
✓ stack 2.9.1
✔✔ stack 2.9.3 recommended
✔✔ ghcup 0.1.19.4 latest,recommended and yet
so I assume it used the nix provided compiler I still need to confirm that hls is actually working. But it seems to be looking good so far 🤔 |
I got |
That's a good question, I've never checked. It was obvious for GHC/HLS though as it takes ages to build 😛 |
Edit: As below this PR not only bumps GHC but also resolves HLS for Apple Silicon users, meaning all contributors can now source all dependencies straight from Nix! 🎉
Notes for reviewers (given divergent OS/arch):
Assuming HLS doesn't work, ensure that you can source GHC 9.4.6 and HLS from ghcup. From a quick look I think it should be available.HLS can now be sourced from Nix for all contributors! 🎉* Try this patch and see if it yells at you (it'd fail on master, and GitHub has no ARM runners for us to
nix flake check
against):