Don't show the repo target publicly #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magellol
approved these changes
Sep 15, 2023
|
We should amend the commits to redact this off if it's considered sensitive. |
|
I can see lots of prominent examples of these being left out in the open: https://github.com/search?q=dkr.ecr.us-west-2.amazonaws.com+language%3AShell&type=code&l=Shell Is there AWS documentation/similar explaining why this should be considered sensitive? Edit: It may also not hide it from the Docker logs: https://github.com/unsplash/mercury/actions/runs/6199893624/job/16833399222#step:5:55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the hard coded repo target.
Not much of a secret anymore but at least is not there.