This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Add per_page param to search photos #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @spencerfdavis! Thanks for adding it. Implementation looks good to me. Our CI's a little bungled right now, currently looking into it. Will accept this once that issue is resolved :) |
|
Hi @spencerfdavis, Sorry for the delay. I haven't forgotten about this! After more than a dozen back-and-forth emails, I've found the issue with our CI. I'm hoping it will be resolved shortly. While I'm confident that this PR isn't breaking our tests, it's a dangerous precedent to bypass CI. Thanks for your patience :) Hopefully you've been able to use your fork without issue in the meantime? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API endpoint allows for
per_pageparam. Added it for the search endpoint.