Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade minimum support version #20

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Downgrade minimum support version #20

merged 1 commit into from
Nov 18, 2020

Conversation

vladyslav-iosdev
Copy link
Contributor

Downgrade minimum support version
remove [weak self] in public func owner(domain: String, completion: @escaping StringResultConsumer ) {

completion get not called when using weak

merenkoff
merenkoff reviewed Nov 9, 2020
View reviewed changes
UnstoppableDomainsResolution.podspec Outdated
@@ -14,7 +14,7 @@ Pod::Spec.new do |spec|
spec.author = { "JohnnyJumper" => "jeyhunt@gmail.com", "Sergei Merenkov" => "mer.sergei@gmail.com", "Roman Medvid" => "roman@unstoppabledomains.com" }
spec.social_media_url = 'https://twitter.com/unstoppableweb'

spec.ios.deployment_target = "12.1"
spec.ios.deployment_target = "10.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swift 5 not supported with iOS10 as I know.

UnstoppableDomainsResolution.podspec Outdated Show resolved Hide resolved
Sources/UnstoppableDomainsResolution/Resolution.swift Outdated Show resolved Hide resolved
Resolution.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Outdated Show resolved Hide resolved
@merenkoff merenkoff added the enhancement New feature or request label Nov 9, 2020
@merenkoff merenkoff self-assigned this Nov 9, 2020
@merenkoff
Copy link
Contributor

If you need iOS 10 support I will check the possibility, how we could provide it...

@vladyslav-iosdev What project do you develop, where is our library is necessary?

@merenkoff
Copy link
Contributor

Also about weak. Please read our docs...

NOTE: make sure an instance of the Resolution class is not deallocated until the asyncronous call brings in the result.

@vladyslav-iosdev
Copy link
Contributor Author

If you need iOS 10 support I will check the possibility, how we could provide it...

i am working on https://github.com/AlphaWallet/alpha-wallet-ios
i saw u commented pr (thanks a lot for u reply). I updated PR files, removed all unnecessary changes.

@vladyslav-iosdev
Copy link
Contributor Author

@merenkoff i updated changes with ios 11, it should work with swift 5 version.

@merenkoff merenkoff merged commit 6d4da0f into unstoppabledomains:master Nov 18, 2020
@vladyslav-iosdev
Copy link
Contributor Author

@merenkoff Thanks a lot ;)

@merenkoff
Copy link
Contributor

Congratulations! 🎉 This was released as part of Release 0.1.6 🚀

Generated by GitBuddy

@merenkoff
Copy link
Contributor

Congratulations! 🎉 This was released as part of Release 1.1.5 🚀

Generated by GitBuddy

@merenkoff
Copy link
Contributor

Congratulations! 🎉 This was released as part of Release 0.1.6 🚀

Generated by GitBuddy

@merenkoff
Copy link
Contributor

Congratulations! 🎉 This was released as part of Release 0.1.7 🚀

Generated by GitBuddy

@merenkoff
Copy link
Contributor

Congratulations! 🎉 This was released as part of Release 0.2.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merenkoff merenkoff merenkoff approved these changes

Assignees

@merenkoff merenkoff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladyslav-iosdev @merenkoff