UNS support #50
Merged
UNS support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove crypto validation except .zil * remove specific domain constant
* Added erc methods
* update proxy reader abi * fix abi parsing due to new abi * isSupportedDomain * update tests * don't check for isSupported under the hood, instead if ending is on .zil use zns otherwise use uns * code clean issupported
Johnny/enable uns
* Use event for unhash * Add pulling registry from proxy reader * Tests for abicoder, remove unused code
…cy (moved to support files) (#49)
* Revert "Merge pull request #41 from unstoppabledomains/removeEns" This reverts commit a1cbfea, reversing changes made to 4ea6607. * changelog * update getServiceOf * revert he changes in podspec * make sure uns will not recognize the ens domains * Update Sources/UnstoppableDomainsResolution/Resolution.swift * Update Sources/UnstoppableDomainsResolution/NamingServices/ENS.swift * my fixes Co-authored-by: Sergei Merenkov <mer.sergei@gmail.com>
allow any network as long as proxyReader contract is defined
DeRain
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
@merenkoff PR looks ready to go. Could you make a release of new major version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.