Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#174576563] Add ZNS support to swift resolution library #6

Merged
merged 4 commits into from
Sep 18, 2020

Conversation

merenkoff
Copy link
Contributor

No description provided.

@merenkoff merenkoff changed the title [#174576563] Add ZNS support to swift resolution library 🚧 [#174576563] Add ZNS support to swift resolution library Sep 10, 2020
@merenkoff merenkoff changed the title 🚧 [#174576563] Add ZNS support to swift resolution library [#174576563] Add ZNS support to swift resolution library Sep 14, 2020
@merenkoff merenkoff marked this pull request as ready for review September 14, 2020 21:19
@merenkoff
Copy link
Contributor Author

ready for review

Copy link
Contributor

@DeRain DeRain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've requested changes, but most of them are styling and naming.

Sources/Resolution/NamingServices/ZNS.swift Outdated Show resolved Hide resolved
Sources/Resolution/NamingServices/ZNS.swift Outdated Show resolved Hide resolved
Sources/Resolution/NamingServices/ZNS.swift Outdated Show resolved Hide resolved
Sources/Resolution/NamingServices/ZNS.swift Outdated Show resolved Hide resolved
Sources/Resolution/NamingServices/ZNS.swift Show resolved Hide resolved
Sources/Resolution/NamingServices/ZNS.swift Outdated Show resolved Hide resolved
@merenkoff
Copy link
Contributor Author

@DeRain please review it again

@merenkoff merenkoff merged commit f40c6a4 into master Sep 18, 2020
@merenkoff merenkoff deleted the feature/ZNS branch September 18, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants