Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DT-802] chore: Update configs #75

Merged

Conversation

DancingAxolotl
Copy link
Contributor

Background

Updating configs to pull record updates

Changes

Pulled new version of resolver-keys.json and uns-config.json configs

Code Review

This Pull Request was thoroughly reviewed and meets all Code Review Standards pertaining to:

  • Implementation - satisfied acceptance criteria
  • Communication - notified engineers/stakeholders about impactful changes
  • Error handling - handled, logged & alerted on errors
  • Documentation - wrote readable code & commits, documented unintuitive code
  • Testing - unit & E2E test coverage, tested in staging, DB migrations backwards compatible
  • Security - sanitized inputs, vetted dependencies, validated/secured API requests, no committed secrets
  • Performance - optimized expensive algorithms & database queries

Please select all applied standards relevant to this PR.

Confirmation

  • Assignee Confirmation - I (the author) have filled out the template above
  • Reviewer Confirmation - I (a/the reviewer) confirm 1) the author has filled out the template and checked the box that says Assignee Confirmation 2) I reviewed the code and selected all applicable items in the code review section.

@DancingAxolotl DancingAxolotl requested a review from a team December 21, 2022 13:01
@DancingAxolotl DancingAxolotl force-pushed the mike/DT-802/update-requested-single-chain-tokens branch from 094042d to 1d57d8e Compare February 3, 2023 19:21
@DancingAxolotl DancingAxolotl force-pushed the mike/DT-802/update-requested-single-chain-tokens branch from 1d57d8e to d63be34 Compare February 7, 2023 10:42
@DancingAxolotl DancingAxolotl force-pushed the mike/DT-802/update-requested-single-chain-tokens branch from de64f8a to 6c6b64d Compare February 7, 2023 11:51
@DancingAxolotl DancingAxolotl merged commit a9b6bea into master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants