pair configuration: collections = null is not a good default.

[untitaker]

null implies that the user entered direct URLs and paths to a collection. This is useful behavior in the case where collection discovery is completely broken on the server, but it is only rarely used and therefore a bad default. We have two options: PLAN:

• Require a value, no default done in 0.9.0
• Change the default, I suggest ["from a", "from b"] 1.0

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[lfam]

On Wed, Feb 03, 2016 at 02:05:29PM -0800, Markus Unterwaditzer wrote:

null implies that the user entered direct URLs and paths to a
collection. This is useful behavior in the case where collection
discovery is completely broken on the server, but it is only rarely
used and therefore a bad default. We have two options:

• Change the default, I suggest ["from a", "from b"]

Since vdirsyncer sync syncs all configured pairs, then I think it
makes sense for this default to be to sync all collections from both
sides, which I think is what you are suggesting here.

• Require a value, no default

---

Reply to this email directly or view it on GitHub:
#328

[untitaker]

which I think is what you are suggesting here

Yes, but...

vdirsyncer sync syncs all configured pairs and collections, but the collections parameter defines the "configured collections". I'm not sure your analogy holds.

• All collections from both sides = All collections that are discoverable (through the DAV user account) or for which a local folder exists
• All configured collections = What is defined in collections.

[lfam]

On Thu, Feb 04, 2016 at 11:33:08AM -0800, Markus Unterwaditzer wrote:

which I think is what you are suggesting here

Yes, but...

vdirsyncer sync syncs all configured pairs and collections, but the collections parameter defines the "configured collections". I'm not sure your analogy holds.

• All collections from both sides = All collections that are discoverable (through the DAV user account) or for which a local folder exists
• All configured collections = What is defined in collections.

You're right, that is different.

---

Reply to this email directly or view it on GitHub:
#328 (comment)

[untitaker]

In #331 I've decided to explicitly require the collections parameter for now. We may re-add a default later on, but I fear that simply changing the default would break user's configuration in too subtle ways.

[untitaker]

0.9 is released without default, next release will be with new default.

[untitaker]

Removing from 1.0 milestone since re-adding a default is not a breakage. However, I wonder if we ever should readd a default at all.