Remove error-swallowing try/catch blocks (#139)

Closes #130
unvt · Dec 20, 2022 · f6f0ced · f6f0ced
1 parent a207fbb
commit f6f0ced
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 26 deletions.
diff --git a/src/commands/build.ts b/src/commands/build.ts
@@ -94,11 +94,7 @@ export async function build(
     }
   }
 
-  try {
-    fs.writeFileSync(destinationPath, style)
-  } catch (err) {
-    throw `${destinationPath}: Permission denied`
-  }
+  fs.writeFileSync(destinationPath, style)
 }
 
 export function buildWatch(

diff --git a/src/commands/convert.ts b/src/commands/convert.ts
@@ -45,11 +45,7 @@ export function convert(source: string, destination: string) {
       const style = JSON.parse(lines.join(''))
       const destinationPath = getDestinationPath(destination)
 
-      try {
-        writeYaml(destinationPath, style, false)
-      } catch (err) {
-        throw `${destinationPath}: Permission denied`
-      }
+      writeYaml(destinationPath, style, false)
     })
   } else {
     sourcePath = path.resolve(process.cwd(), source)
@@ -67,10 +63,6 @@ export function convert(source: string, destination: string) {
 
     const destinationPath = getDestinationPath(destination, sourcePath)
 
-    try {
-      writeYaml(destinationPath, style, false)
-    } catch (err) {
-      throw `${destinationPath}: Permission denied`
-    }
+    writeYaml(destinationPath, style, false)
   }
 }
diff --git a/src/lib/build-sprite.ts b/src/lib/build-sprite.ts
@@ -1,5 +1,5 @@
 import { generateSprite } from '@unvt/sprite-one'
-const path = require('path')
+import path from 'path'
 
 export async function buildSprite(
   svgPath: string,
@@ -8,10 +8,6 @@ export async function buildSprite(
 ): Promise<void> {
   const pxRatios = [1, 2]
   const outPath = path.join(publicPath, iconSlug)
-  try {
-    await generateSprite(outPath, [svgPath], pxRatios)
-  } catch (error) {
-    throw error
-  }
+  await generateSprite(outPath, [svgPath], pxRatios)
   return
 }
diff --git a/src/lib/yaml-writer.ts b/src/lib/yaml-writer.ts
@@ -30,11 +30,7 @@ const writeCompositedYaml = (
     stylePath = destinationPath
   }
 
-  try {
-    fs.writeFileSync(stylePath, styleYAML)
-  } catch (err) {
-    throw `${stylePath}: Permission denied`
-  }
+  fs.writeFileSync(stylePath, styleYAML)
 }
 
 const writeDecompositedYaml = (