Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"/" in layer id #56

Closed
ubukawa opened this issue Nov 24, 2021 · 4 comments · Fixed by #121
Closed

"/" in layer id #56

ubukawa opened this issue Nov 24, 2021 · 4 comments · Fixed by #121
Labels
help wanted Extra attention is needed

Comments

@ubukawa
Copy link
Contributor

ubukawa commented Nov 24, 2021

Warm greetings.

Today, I found an issue.
If there is a "/" in any layer id, we see "the permission denied" and the "convert" command does not work. (See attached image.)
2021-11-24-error

I think this is because the layer "id" will be the name of each layer's yml file.

But, if we look at the style file from ArcGIS series, we may see a lot of "/" in layers' id.
Do you think is there any way to overcome this issue?
Otherwise, the charites will not be used to import a style file from ESRI sometimes.

Thank you for your kind attention and kind advice!

(FYI) An default style of Esri Living Atlas
https://basemaps.arcgis.com/arcgis/rest/services/OpenStreetMap_v2/VectorTileServer/resources/styles/root.json

@ubukawa ubukawa added the help wanted Extra attention is needed label Nov 24, 2021
@ubukawa
Copy link
Contributor Author

ubukawa commented Dec 6, 2021

Tentatively, I replaced "/" with "(slash)" using the text editor. Then, we can import the style.json into yaml files.

@ubukawa
Copy link
Contributor Author

ubukawa commented Dec 6, 2021

This is how I tentatively avoid this issue.
https://qiita.com/T-ubu/items/e6794b81e45dea34548c

Then, I close this issue.

@ubukawa ubukawa closed this as completed Dec 6, 2021
@JinIgarashi
Copy link
Member

@naogify I think this issue should be solved by source code. What do you think?

@naogify
Copy link
Contributor

naogify commented Dec 7, 2021

@JinIgarashi @ubukawa
Yes, I agree with your opinion. I think we can solve the problem by source code.

@naogify naogify reopened this Dec 7, 2021
keichan34 added a commit to keichan34/charites that referenced this issue Nov 24, 2022
@keichan34 keichan34 mentioned this issue Nov 24, 2022
11 tasks
keichan34 added a commit to keichan34/charites that referenced this issue Dec 1, 2022
keichan34 added a commit that referenced this issue Dec 1, 2022
* Support slash in layer ID

Closes #56

* Fix convert when running on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants