This repository has been archived by the owner on May 8, 2024. It is now read-only.
Cleanup some cruft that seems to have been left over from old refactorings (v2) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the block is simply called, it does not need to be bound to a variable. This will also make #invoke a bit faster.
Also, unindent the code now that it is not wrapped in an if statment. The check is a waste of time given that the argument is mandatory and that there is nothing else being done in the method.
Benchmarking this fact: https://gist.github.com/812863
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revised version of my previous pull request after troelskn pointed out an error in one of my changes.