Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support curveTo #1

Merged
merged 1 commit into from Oct 8, 2012
Merged

Conversation

leethomason
Copy link
Contributor

A simple, initial implementation of curveTo(). A couple areas of improvement are in the notes; I'm happy to tune the function, but wanted to get unblocked from the API not being present at all.

@jonathanrpace
Copy link
Member

Great! Don't suppose you fancy tackling cubicCurveTo while you're there? :)

One suggestion - is it worth passing the 'numDivisions' as an optional parameter, with a default value of 8? That way if people need to tweak it, there's no need to open up the class.

@robsilv
Copy link
Member

robsilv commented Oct 6, 2012

Thanks Lee, your contributions are obviously very welcome! :D

@leethomason
Copy link
Contributor Author

@jonathanrpace, Good reminder on the cubics. Beginning of the week I'll add the cubics, and also add a proper error metric for the quadratics so it can compute a reasonable number of "numDivisions" for you. That will be much better than the current hardcoded value, and if we stiff need tuning that can be added later.

@robsilv You are welcome - glad to see this getting momentum!

jonathanrpace added a commit that referenced this pull request Oct 8, 2012
@jonathanrpace jonathanrpace merged commit 0e711d3 into StarlingGraphics:master Oct 8, 2012
IonSwitz added a commit that referenced this pull request Oct 24, 2013
Pulling the Master to the IonSwitz fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants