Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing _window with self.window in PangolinNSGLView.mm #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keefo
Copy link

@keefo keefo commented Jan 2, 2021

compiling under macOS Big Sur with Xcode 12 cause the following error:

      'wantsBestResolutionOpenGLSurface' has been explicitly marked deprecated here
PangolinNSGLView.mm:75:55: error: use of undeclared identifier '_window'
    if ( [self wantsBestResolutionOpenGLSurface] && [ _window respondsToSelector:@selector(backingScaleFactor) ] )
                                                      ^
PangolinNSGLView.mm:76:26: error: use of undeclared identifier '_window'
        backing_scale = [_window backingScaleFactor];
                         ^

Replacing _window with self.window in src/display/device/PangolinNSGLView.mm to fix the issue,

compile under macOS Big Sur with Xcode 12 cause the following error:

```
      'wantsBestResolutionOpenGLSurface' has been explicitly marked deprecated here
PangolinNSGLView.mm:75:55: error: use of undeclared identifier '_window'
    if ( [self wantsBestResolutionOpenGLSurface] && [ _window respondsToSelector:@selector(backingScaleFactor) ] )
                                                      ^
PangolinNSGLView.mm:76:26: error: use of undeclared identifier '_window'
        backing_scale = [_window backingScaleFactor];
                         ^
```
@keefo keefo changed the title replacing _window with self.window replacing _window with self.window in src/display/device/PangolinNSGLView.mm Jan 2, 2021
@keefo keefo changed the title replacing _window with self.window in src/display/device/PangolinNSGLView.mm replacing _window with self.window in PangolinNSGLView.mm Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant