Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can anyone compile this for Mac OS Big Sur? #35

Open
kir486680 opened this issue Dec 21, 2020 · 10 comments
Open

Can anyone compile this for Mac OS Big Sur? #35

kir486680 opened this issue Dec 21, 2020 · 10 comments

Comments

@kir486680
Copy link

No description provided.

@keefo
Copy link

keefo commented Jan 2, 2021

I just compiled it on macOS Big Sur 11.0.1 with Xcode Version 12.3 (12C33)
You need to fix a minor issue before you could compile it.

src/display/device/PangolinNSGLView.mm

and replace all _window with self.window

@keefo
Copy link

keefo commented Jan 2, 2021

PR #36

@kir486680
Copy link
Author

kir486680 commented Jan 5, 2021

@keefo thanks for your solution. However, I run into a new issue

include/pangolin/display/attach.h:33:10: fatal error: 
      'GL/glew.h' file not found
#include <GL/glew.h>

I installed glew with brew but it seems like pangolin cant find it.

@keefo
Copy link

keefo commented Jan 6, 2021

I encounter the same issue as well. I feel like it was some environmental issues. I was able to build it out by replacing include line: #include <GL/glew.h> with an absolute path like this #include <absolutepath_to_/GL/glew.h>

However, this is just a temporary solution that I used. I don't recommend others doing the same.

Later, I did uninstall some packages including python3 and reinstall them through brew. After some mingling around. I was able to rebuild the pangolin without replacing the include line above.

@markoelez
Copy link

markoelez commented May 26, 2021

Try this: https://github.com/markoelez/Pangolin/blob/master/README.md#building

Build works on Big Sur.

@iamkrs9
Copy link

iamkrs9 commented May 27, 2021

not working on Big Sur 11.3.1

@markoelez
Copy link

markoelez commented May 27, 2021

@iamkrs9 what error are you getting? I am running Big Sur 11.3.1 as well and the build works fine.

Screen Shot 2021-05-26 at 10 36 32 PM

@iamkrs9
Copy link

iamkrs9 commented May 27, 2021

This is what happened:
I got pybind11 with brew but it showed some error after the came .. command which was the following:

CMake Error at /usr/local/share/cmake/pybind11/pybind11Common.cmake:173 (if):
if given arguments:

"14" "IN_LIST" "supported_standards"

Unknown arguments specified
Call Stack (most recent call first):
/usr/local/share/cmake/pybind11/pybind11Config.cmake:249 (include)
python/CMakeLists.txt:3 (find_package)

So I deleted the below chunk of code from /usr/local/share/cmake/pybind11/pybind11Common.cmake file:

if(PYBIND11_CPP_STANDARD)
string(REGEX MATCH [[..$]] VAL "${PYBIND11_CPP_STANDARD}")
if(CMAKE_CXX_STANDARD)
if(NOT CMAKE_CXX_STANDARD STREQUAL VAL)
message(WARNING "CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} does not match "
"PYBIND11_CPP_STANDARD=${PYBIND11_CPP_STANDARD}, "
"please remove PYBIND11_CPP_STANDARD from your cache")
endif()
else()
set(supported_standards 11 14 17 20)
if("${VAL}" IN_LIST supported_standards)
message(WARNING "USE -DCMAKE_CXX_STANDARD=${VAL} instead of PYBIND11_CPP_STANDARD")
set(CMAKE_CXX_STANDARD
${VAL}
CACHE STRING "From PYBIND11_CPP_STANDARD")
else()
message(FATAL_ERROR "PYBIND11_CPP_STANDARD should be replaced with CMAKE_CXX_STANDARD "
"(last two chars: ${VAL} not understood as a valid CXX std)")
endif()
endif()
endif()

It compiled after that but could not be imported so I compiled it again after placing the folder in venv/lib/python/site-packages

I can import it now and the program works but the HelloPangolin.py turns up with just a red screen and there is a warning in Pycharm that says "Parameter 'params' unfilled " for the CreateWindowAndBind function.

Screen Shot 2021-05-27 at 8 28 39 AM

@JackWBoynton
Copy link

Finally got it working for Macos Monterey and Python 3.7 ! see my fork: https://github.com/JackWBoynton/pangolin

@markoelez
Copy link

I also have an alternative install script here: https://github.com/markoelez/minislam/blob/master/install_pangolin.sh, might be helpful for someone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants