Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check for python3 str serializing #33 #34

Merged
merged 1 commit into from
Apr 8, 2020
Merged

add check for python3 str serializing #33 #34

merged 1 commit into from
Apr 8, 2020

Conversation

nyxaria
Copy link
Contributor

@nyxaria nyxaria commented Apr 1, 2020

#33

mintar
mintar requested changes Apr 1, 2020
View reviewed changes
Copy link
Member

@mintar mintar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good, but perhaps we should add a comment (see my suggestion).

@mintar
add check for python3 str serializing DFKI-NI#33
0875664 
Co-Authored-By: Martin Günther <martin.guenther@dfki.de>
@nyxaria
Copy link
Contributor Author

nyxaria commented Apr 2, 2020

committed the comment and squashed. I think it's ready for a merge

@nyxaria
Copy link
Contributor Author

nyxaria commented Apr 8, 2020

@mintar should we merge?

@mintar mintar merged commit ff44b97 into DFKI-NI:master Apr 8, 2020
@mintar
Copy link
Member

mintar commented Apr 8, 2020

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mintar mintar mintar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyxaria @mintar