Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove unused suspense wrappers #341

Merged
merged 26 commits into from
Aug 14, 2020

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Aug 12, 2020

Description

Implements issue #338

Reason for this PR

  • We are currently using own wrapper components to render async components with suspense. This is not needed

Changes in this PR

  • I replaced the wrappers including the fallback loading component by implementing the async API calls in the components to render within async functions that are called with the onBeforeMount lifecycle hook. The loading component is rendered via a refed busy boolean that indicates whether the component is loading data or not. (see description in Remove unused Wrappers #338 )

Type of change (remove all that don't apply)

  • Refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows

  • Browser: Firefox

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • No backend needed to test this
    • Deployed master version 0.5.0

Checklist: (remove all that don't apply)

  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

Copy link
Collaborator

@bastihav bastihav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.
One note:

  • Changing the v-if v-else order is a discussion point, feel free to reject those.

CHANGELOG.md Outdated Show resolved Hide resolved
src/components/AccountList.vue Outdated Show resolved Hide resolved
src/components/Versions.vue Outdated Show resolved Hide resolved
src/components/Versions.vue Outdated Show resolved Hide resolved
src/components/Versions.vue Outdated Show resolved Hide resolved
src/views/admin/EditCreateAccountForm.vue Outdated Show resolved Hide resolved
src/views/common/About.vue Outdated Show resolved Hide resolved
src/views/common/Welcome.vue Outdated Show resolved Hide resolved
src/views/common/Welcome.vue Outdated Show resolved Hide resolved
src/views/lecturer/EditCreateCourseForm.vue Outdated Show resolved Hide resolved
tobias-wiese and others added 13 commits August 14, 2020 11:03
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
Co-authored-by: Bastian Haverkamp <bastihav@mail.upb.de>
@tobias-wiese tobias-wiese merged commit 340f59d into develop Aug 14, 2020
@tobias-wiese tobias-wiese deleted the refactor/remove_unused_suspense_wrappers branch August 14, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants