Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-User-Signing Dashboard #785

Merged
merged 121 commits into from
Jan 25, 2021
Merged

Conversation

tobias-wiese
Copy link
Contributor

@tobias-wiese tobias-wiese commented Jan 6, 2021

Description

Reason for this PR

  • The user needs options for handling operations concerning his account, that require multiple parties to approve

Changes in this PR

  • Including operations API 1.0
  • Create dashboard for handling finished, pending and action required operations (replaced the current welcome page)
  • Create a page for displaying all archived operations
  • Create a page containing all ongoing operations for the admin
  • Add a toast indicating that a multi-user-signing operation was successfully submitted

Type of change (remove all that don't apply)

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually tested all use cases this could alter

Test Configuration:

  • OS: Windows Mac Linux

  • Browser: Firefox Chrome Safari Chromium

  • Frontend: (remove all that don't apply)

    • Development build
  • Backend: (remove all that don't apply)

    • deployed development build
    • deployed experimental build

Checklist: (remove all that don't apply)

  • I added corresponding E2E tests (especially for bugfixes)
  • I added corresponding unit tests (if API code)
  • I have performed a self-review of my own code
  • My changes generate no new linting warnings or console warnings
  • I have updated the CHANGELOG.md to include any changes made in this PR (add WIP to the top, if there is none already)

Note for Reviewers:

I know that there are some TODOs in the code and that we decide to not push those on dev. In this case, I decided to let them be as they are, as they are todos for the watchlist functions that will come with operations 1.1, which logic I already implemented during the designing process.

@tobias-wiese tobias-wiese added enhancement New feature or request vue labels Jan 6, 2021
@this-kramer
Copy link
Contributor

Screenshot from 2021-01-25 17-00-17

The items on the right look a little broken. Maybe put the Finished Operations over Action Required and only show the first three or so (and an expand button) to make them full width?

Copy link
Contributor

@this-kramer this-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Only minor annotations :)

src/components/common/dashboard/Dashboard.vue Outdated Show resolved Hide resolved
src/components/common/dashboard/Dashboard.vue Show resolved Hide resolved
src/components/common/dashboard/Dashboard.vue Outdated Show resolved Hide resolved
src/components/common/dashboard/Dashboard.vue Outdated Show resolved Hide resolved
src/components/common/dashboard/DashboardComponent.vue Outdated Show resolved Hide resolved
src/views/admin/AllOperations.vue Outdated Show resolved Hide resolved
src/views/admin/AllOperations.vue Show resolved Hide resolved
src/views/common/OperationsArchive.vue Outdated Show resolved Hide resolved
src/views/common/OperationsArchive.vue Show resolved Hide resolved
@tobias-wiese
Copy link
Contributor Author

Screenshot from 2021-01-25 17-00-17

The items on the right look a little broken. Maybe put the Finished Operations over Action Required and only show the first three or so (and an expand button) to make them full width?

should be fixed with d1c18f8

tobias-wiese and others added 17 commits January 25, 2021 17:21
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1@mail.uni-paderborn.de>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1@mail.uni-paderborn.de>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Co-authored-by: Paul Kramer <pkramer1503@gmail.com>
Copy link
Contributor

@this-kramer this-kramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tobias-wiese tobias-wiese merged commit 8071cfc into develop Jan 25, 2021
@tobias-wiese tobias-wiese deleted the feature/operations_dashboard branch January 25, 2021 19:05
@tobias-wiese tobias-wiese mentioned this pull request Jan 26, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experimental Use for testing against "experimental" cluster vue
Projects
None yet
3 participants