-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Configuration and Lock converters #12
Merged
sergenyalcin
merged 20 commits into
upbound:main
from
sergenyalcin:config-meta-converter
Jul 7, 2023
Merged
Adds Configuration and Lock converters #12
sergenyalcin
merged 20 commits into
upbound:main
from
sergenyalcin:config-meta-converter
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
changed the title
Adds meta.Configuration converters
Adds Configuration and Lock converters
Jun 20, 2023
ulucinar
reviewed
Jun 22, 2023
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
ulucinar
reviewed
Jul 2, 2023
ulucinar
reviewed
Jul 2, 2023
ulucinar
reviewed
Jul 2, 2023
ulucinar
reviewed
Jul 2, 2023
ulucinar
reviewed
Jul 2, 2023
ulucinar
reviewed
Jul 2, 2023
ulucinar
reviewed
Jul 2, 2023
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
config-meta-converter
branch
from
July 4, 2023 13:40
daee78a
to
82a76da
Compare
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
…es source for conditional orphaning Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
… parent as the plan file Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
config-meta-converter
branch
from
July 6, 2023 13:10
193c5bf
to
aba1102
Compare
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
3 tasks
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sergenyalcin, lgtm. Let's update the upjet dependency and merge this PR.
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds meta.Configuration, pkg.Configuration and Lock converters.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested against crossplane/upjet#217 using the configuration package
index.docker.io/ulucinar/family-migrator-test:v0.1.0
and the configuration source repo: https://github.com/ulucinar/alper-test-configuration/tree/family-migrator-test.