Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors can also trigger e2e #47

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Nov 21, 2022

Description of your changes

Contributors should also be able trigger e2e.

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

To be tested with crossplane-contrib/provider-upjet-aws#144 after merge.

Signed-off-by: Hasan Turken <turkenh@gmail.com>
Copy link
Contributor

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenh, lgtm.

@turkenh turkenh merged commit 65a5a7e into upbound:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants