Upgrade terraform binary to v1.5.2 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
bobh66,
negz,
ulucinar and
sergenyalcin
as code owners
Fixes upbound#172 Signed-off-by: Yury Tsarev <yury@upbound.io>
Newer zips are failing with ``` unzip: zip flag 8 (streaming) is not supported ``` Signed-off-by: Yury Tsarev <yury@upbound.io>
|
/test-examples="examples/workspace-inline-aws.yaml" |
Getting this feedback from uptest, it looks like this upgrade will need more love than just the version bump :) |
This is a difference between the aws terraform provider version 4.x and 5.x. What's not obvious to me (but hopefully is to you) is why upgrading the terraform version would automatically update the version of the aws provider. |
If you don't pin the provider version it will often/usually upgrade to the latest provider on a new deployment (cache is empty) as it always pulls the latest version unless you tell it to pull a specific version |
|
/test-examples="examples/workspace-inline-aws.yaml" |
Signed-off-by: Yury Tsarev <yury@upbound.io>
|
/test-examples="examples/workspace-inline-aws.yaml" |
|
@bobh66 it seems that stuff got green, please review :) |
bobh66
approved these changes
Jun 30, 2023
| ENV TF_IN_AUTOMATION=1 | ||
| ENV TF_PLUGIN_CACHE_DIR=/tf/plugin-cache | ||
|
|
||
| ADD "bin/${TARGETOS}_${TARGETARCH}/provider" /usr/local/bin/crossplane-terraform-provider | ||
| ADD .gitconfig .gitconfig | ||
|
|
||
| RUN curl -s -L https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_${TARGETOS}_${TARGETARCH}.zip | \ | ||
| unzip -d /usr/local/bin - \ | ||
| RUN curl -s -L https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_${TARGETOS}_${TARGETARCH}.zip -o terraform.zip \ |
There was a problem hiding this comment.
Just curious why this change is needed?
There was a problem hiding this comment.
unzip from the pipe stream is failing with the new terraform zips
unzip: zip flag 8 (streaming) is not supported
so it breaks the build.
The closest issue upstream I found is richgel999/miniz#180 .
Instead of diving into unzip specifics, I just decided to unzip it simple file-based way :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #172
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
uptest below