Make the terraform harness only use the rwmutex if the plugin cache is enabled #240
+88
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastwaffle
requested review from
bobh66,
ytsarev,
negz,
ulucinar,
sergenyalcin and
turkenf
as code owners
bobh66
reviewed
Feb 1, 2024
|
I have now tested this locally with 4 workspaces with the plugin cache disabled doing long-running applies (GKE cluster creation) in parallel (where previously they'd have gotten stuck), and 4 other workspaces with the plugin cache enabled successfully reconciling some DNS records |
bobh66
approved these changes
Feb 6, 2024
|
@bobh66 does this qualify for an off-schedule release, or does this need to wait until the 29th? |
|
Good question - seems like a good candidate for a backport - I'll see what the release team thinks |
|
Successfully created backport PR #242 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As discussed in #239, this makes the terraform harness only take the lock if the plugin cache is enabled. If the plugin cache is not enabled, there is nothing to protect, and thus no need to take the lock.
This change also removes locking for all
terraform planoperations, on the assumption that conflicts are unlikely, and can easily be retried on a subsequent reconcile if they do happen.I have:
make reviewableto ensure this PR is ready for review. It returned a bunch of type errors which seemed unrelated to this change, but I ranmake testwhich did pass andmake buildwhich did succeed.How has this code been tested
Unit tests