Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify process for creating a new release branch #427

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Feb 9, 2024

Description of your changes

Replacing the original PR: #403

The existing process relying on rebase became more challenging with the recent state. With v1.14 release, I had to resolve conflicts for ~15 commits which even includes a revert.

This PR proposes a simplified one without any rebase, leveraging git diff.

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

See upbound/crossplane#109

Signed-off-by: Hasan Turken <turkenh@gmail.com>
@turkenh turkenh merged commit 84abf1d into upbound:main Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants